-
Notifications
You must be signed in to change notification settings - Fork 706
chore(CI): add goimports to linter #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): add goimports to linter #993
Conversation
|
@ahrtr there is also another formatting tool (i.e. Please let me know if you want to add Also I have added a step to all workflows to run As it is defined in the reusable workflow, i expected it to be running by default, but looks like it was not the case |
|
Now I have to use |
136fc0f to
52025a1
Compare
290f94e to
efab19d
Compare
Signed-off-by: Mustafa Elbehery <[email protected]>
efab19d to
55e2494
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & thx
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, Elbehery, fuweid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I think it would be cleaner if rather than running the linter in every workflow, we ran it along with #986. That way, we can lint all the platform-specific files. |
Agreed, please feel free to enhance it in followup PR, thx |
fixes #992
cc @ahrtr @ivanvc @fuweid