Skip to content

fix maxMapSize typo in aix, android, solaris #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

fix maxMapSize typo in aix, android, solaris #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bolt_aix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"time"
"unsafe"

"go.etcd.io/bbolt/internal/common"
Copy link
Member

@ahrtr ahrtr Jun 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import item should be put in a separate group. It seems that the bbolt workflow can't detect such minor issue.

cc @Elbehery @ivanvc

"golang.org/x/sys/unix"
)

Expand Down Expand Up @@ -69,7 +70,7 @@ func mmap(db *DB, sz int) error {

// Save the original byte slice and convert to a byte array pointer.
db.dataref = b
db.data = (*[maxMapSize]byte)(unsafe.Pointer(&b[0]))
db.data = (*[common.MaxMapSize]byte)(unsafe.Pointer(&b[0]))
db.datasz = sz
return nil
}
Expand Down
3 changes: 2 additions & 1 deletion bolt_android.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"time"
"unsafe"

"go.etcd.io/bbolt/internal/common"
"golang.org/x/sys/unix"
)

Expand Down Expand Up @@ -69,7 +70,7 @@ func mmap(db *DB, sz int) error {

// Save the original byte slice and convert to a byte array pointer.
db.dataref = b
db.data = (*[maxMapSize]byte)(unsafe.Pointer(&b[0]))
db.data = (*[common.MaxMapSize]byte)(unsafe.Pointer(&b[0]))
db.datasz = sz
return nil
}
Expand Down
3 changes: 2 additions & 1 deletion bolt_solaris.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"time"
"unsafe"

"go.etcd.io/bbolt/internal/common"
"golang.org/x/sys/unix"
)

Expand Down Expand Up @@ -67,7 +68,7 @@ func mmap(db *DB, sz int) error {

// Save the original byte slice and convert to a byte array pointer.
db.dataref = b
db.data = (*[maxMapSize]byte)(unsafe.Pointer(&b[0]))
db.data = (*[common.MaxMapSize]byte)(unsafe.Pointer(&b[0]))
db.datasz = sz
return nil
}
Expand Down