-
Notifications
You must be signed in to change notification settings - Fork 707
fix maxMapSize typo in aix, android, solaris #988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Asutorufa <[email protected]>
|
Hi @Asutorufa. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
ahrtr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, Asutorufa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| "time" | ||
| "unsafe" | ||
|
|
||
| "go.etcd.io/bbolt/internal/common" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit fde6016, reversing changes made to 8919474. Signed-off-by: Ivan Valdes <[email protected]>
In https://github.com/openbao/openbao/actions/runs/15883186152/job/44788865022, the Illumos build failed. This was due to the etcd build failing: > • building build={builds-other [illumos] [amd64 arm arm64 riscv64] [v1] [sse2] [6 7] [v8.0] [hardfloat] [power8] [rva20u64] [illumos_amd64_v1] [{linux } {darwin 6 } {darwin arm } {darwin riscv64 } {dragonfly arm } {dragonfly arm64 } {dragonfly riscv64 } {freebsd 7 } {illumos arm } {illumos arm64 } {netbsd riscv64 } {netbsd 7 } {openbsd riscv64 } {openbsd 7 } {windows arm 7 } {windows riscv64 }] . . bao {[] []} go {{ .CommitTimestamp }} false go build false { [-X github.com/openbao/openbao/version.fullVersion={{.Version}} -X github.com/openbao/openbao/version.GitCommit={{.Commit}} -X github.com/openbao/openbao/version.BuildDate={{ .Date }}] [ui] [] [] [] [CGO_ENABLED=0]} []} > • building binary=dist/builds-other_illumos_amd64_v1/bao > • env "CGO_ENABLED=0" evaluated to "CGO_ENABLED=0" > • running > • took: 2m0s > ⨯ release failed after 2m29s error=build failed: failed to build for illumos_amd64_v1: exit status 1: # go.etcd.io/bbolt > Error: ../../../go/pkg/mod/go.etcd.io/[email protected]/bolt_solaris.go:70:15: undefined array length maxMapSize or missing type constraint > > target: illumos_amd64_v1 > Error: Process completed with exit code 1. See also: etcd-io/bbolt#988 Signed-off-by: Alexander Scheel <[email protected]>
In https://github.com/openbao/openbao/actions/runs/15883186152/job/44788865022, the Illumos build failed. This was due to the etcd build failing: > • building build={builds-other [illumos] [amd64 arm arm64 riscv64] [v1] [sse2] [6 7] [v8.0] [hardfloat] [power8] [rva20u64] [illumos_amd64_v1] [{linux } {darwin 6 } {darwin arm } {darwin riscv64 } {dragonfly arm } {dragonfly arm64 } {dragonfly riscv64 } {freebsd 7 } {illumos arm } {illumos arm64 } {netbsd riscv64 } {netbsd 7 } {openbsd riscv64 } {openbsd 7 } {windows arm 7 } {windows riscv64 }] . . bao {[] []} go {{ .CommitTimestamp }} false go build false { [-X github.com/openbao/openbao/version.fullVersion={{.Version}} -X github.com/openbao/openbao/version.GitCommit={{.Commit}} -X github.com/openbao/openbao/version.BuildDate={{ .Date }}] [ui] [] [] [] [CGO_ENABLED=0]} []} > • building binary=dist/builds-other_illumos_amd64_v1/bao > • env "CGO_ENABLED=0" evaluated to "CGO_ENABLED=0" > • running > • took: 2m0s > ⨯ release failed after 2m29s error=build failed: failed to build for illumos_amd64_v1: exit status 1: # go.etcd.io/bbolt > Error: ../../../go/pkg/mod/go.etcd.io/[email protected]/bolt_solaris.go:70:15: undefined array length maxMapSize or missing type constraint > > target: illumos_amd64_v1 > Error: Process completed with exit code 1. If this is fixed with a corresponding action build + test verification, we can revert this. See also: etcd-io/bbolt#988 Signed-off-by: Alexander Scheel <[email protected]>
In https://github.com/openbao/openbao/actions/runs/15883186152/job/44788865022, the Illumos build failed. This was due to the etcd build failing: > • building build={builds-other [illumos] [amd64 arm arm64 riscv64] [v1] [sse2] [6 7] [v8.0] [hardfloat] [power8] [rva20u64] [illumos_amd64_v1] [{linux } {darwin 6 } {darwin arm } {darwin riscv64 } {dragonfly arm } {dragonfly arm64 } {dragonfly riscv64 } {freebsd 7 } {illumos arm } {illumos arm64 } {netbsd riscv64 } {netbsd 7 } {openbsd riscv64 } {openbsd 7 } {windows arm 7 } {windows riscv64 }] . . bao {[] []} go {{ .CommitTimestamp }} false go build false { [-X github.com/openbao/openbao/version.fullVersion={{.Version}} -X github.com/openbao/openbao/version.GitCommit={{.Commit}} -X github.com/openbao/openbao/version.BuildDate={{ .Date }}] [ui] [] [] [] [CGO_ENABLED=0]} []} > • building binary=dist/builds-other_illumos_amd64_v1/bao > • env "CGO_ENABLED=0" evaluated to "CGO_ENABLED=0" > • running > • took: 2m0s > ⨯ release failed after 2m29s error=build failed: failed to build for illumos_amd64_v1: exit status 1: # go.etcd.io/bbolt > Error: ../../../go/pkg/mod/go.etcd.io/[email protected]/bolt_solaris.go:70:15: undefined array length maxMapSize or missing type constraint > > target: illumos_amd64_v1 > Error: Process completed with exit code 1. If this is fixed with a corresponding action build + test verification, we can revert this. See also: etcd-io/bbolt#988 Signed-off-by: Alexander Scheel <[email protected]>
* Drop Illumos support per policy in #711 In https://github.com/openbao/openbao/actions/runs/15883186152/job/44788865022, the Illumos build failed. This was due to the etcd build failing: > • building build={builds-other [illumos] [amd64 arm arm64 riscv64] [v1] [sse2] [6 7] [v8.0] [hardfloat] [power8] [rva20u64] [illumos_amd64_v1] [{linux } {darwin 6 } {darwin arm } {darwin riscv64 } {dragonfly arm } {dragonfly arm64 } {dragonfly riscv64 } {freebsd 7 } {illumos arm } {illumos arm64 } {netbsd riscv64 } {netbsd 7 } {openbsd riscv64 } {openbsd 7 } {windows arm 7 } {windows riscv64 }] . . bao {[] []} go {{ .CommitTimestamp }} false go build false { [-X github.com/openbao/openbao/version.fullVersion={{.Version}} -X github.com/openbao/openbao/version.GitCommit={{.Commit}} -X github.com/openbao/openbao/version.BuildDate={{ .Date }}] [ui] [] [] [] [CGO_ENABLED=0]} []} > • building binary=dist/builds-other_illumos_amd64_v1/bao > • env "CGO_ENABLED=0" evaluated to "CGO_ENABLED=0" > • running > • took: 2m0s > ⨯ release failed after 2m29s error=build failed: failed to build for illumos_amd64_v1: exit status 1: # go.etcd.io/bbolt > Error: ../../../go/pkg/mod/go.etcd.io/[email protected]/bolt_solaris.go:70:15: undefined array length maxMapSize or missing type constraint > > target: illumos_amd64_v1 > Error: Process completed with exit code 1. If this is fixed with a corresponding action build + test verification, we can revert this. See also: etcd-io/bbolt#988 Signed-off-by: Alexander Scheel <[email protected]> * Bump changelog version to v2.3.1 Signed-off-by: Alexander Scheel <[email protected]> --------- Signed-off-by: Alexander Scheel <[email protected]>
…bao#1503) * Drop Illumos support per policy in openbao#711 In https://github.com/openbao/openbao/actions/runs/15883186152/job/44788865022, the Illumos build failed. This was due to the etcd build failing: > • building build={builds-other [illumos] [amd64 arm arm64 riscv64] [v1] [sse2] [6 7] [v8.0] [hardfloat] [power8] [rva20u64] [illumos_amd64_v1] [{linux } {darwin 6 } {darwin arm } {darwin riscv64 } {dragonfly arm } {dragonfly arm64 } {dragonfly riscv64 } {freebsd 7 } {illumos arm } {illumos arm64 } {netbsd riscv64 } {netbsd 7 } {openbsd riscv64 } {openbsd 7 } {windows arm 7 } {windows riscv64 }] . . bao {[] []} go {{ .CommitTimestamp }} false go build false { [-X github.com/openbao/openbao/version.fullVersion={{.Version}} -X github.com/openbao/openbao/version.GitCommit={{.Commit}} -X github.com/openbao/openbao/version.BuildDate={{ .Date }}] [ui] [] [] [] [CGO_ENABLED=0]} []} > • building binary=dist/builds-other_illumos_amd64_v1/bao > • env "CGO_ENABLED=0" evaluated to "CGO_ENABLED=0" > • running > • took: 2m0s > ⨯ release failed after 2m29s error=build failed: failed to build for illumos_amd64_v1: exit status 1: # go.etcd.io/bbolt > Error: ../../../go/pkg/mod/go.etcd.io/[email protected]/bolt_solaris.go:70:15: undefined array length maxMapSize or missing type constraint > > target: illumos_amd64_v1 > Error: Process completed with exit code 1. If this is fixed with a corresponding action build + test verification, we can revert this. See also: etcd-io/bbolt#988 Signed-off-by: Alexander Scheel <[email protected]> * Bump changelog version to v2.3.1 Signed-off-by: Alexander Scheel <[email protected]> --------- Signed-off-by: Alexander Scheel <[email protected]>
* Drop Illumos support per policy in #711 In https://github.com/openbao/openbao/actions/runs/15883186152/job/44788865022, the Illumos build failed. This was due to the etcd build failing: > • building build={builds-other [illumos] [amd64 arm arm64 riscv64] [v1] [sse2] [6 7] [v8.0] [hardfloat] [power8] [rva20u64] [illumos_amd64_v1] [{linux } {darwin 6 } {darwin arm } {darwin riscv64 } {dragonfly arm } {dragonfly arm64 } {dragonfly riscv64 } {freebsd 7 } {illumos arm } {illumos arm64 } {netbsd riscv64 } {netbsd 7 } {openbsd riscv64 } {openbsd 7 } {windows arm 7 } {windows riscv64 }] . . bao {[] []} go {{ .CommitTimestamp }} false go build false { [-X github.com/openbao/openbao/version.fullVersion={{.Version}} -X github.com/openbao/openbao/version.GitCommit={{.Commit}} -X github.com/openbao/openbao/version.BuildDate={{ .Date }}] [ui] [] [] [] [CGO_ENABLED=0]} []} > • building binary=dist/builds-other_illumos_amd64_v1/bao > • env "CGO_ENABLED=0" evaluated to "CGO_ENABLED=0" > • running > • took: 2m0s > ⨯ release failed after 2m29s error=build failed: failed to build for illumos_amd64_v1: exit status 1: # go.etcd.io/bbolt > Error: ../../../go/pkg/mod/go.etcd.io/[email protected]/bolt_solaris.go:70:15: undefined array length maxMapSize or missing type constraint > > target: illumos_amd64_v1 > Error: Process completed with exit code 1. If this is fixed with a corresponding action build + test verification, we can revert this. See also: etcd-io/bbolt#988 * Bump changelog version to v2.3.1 --------- Signed-off-by: Alexander Scheel <[email protected]>
* Drop Illumos support per policy in #711 In https://github.com/openbao/openbao/actions/runs/15883186152/job/44788865022, the Illumos build failed. This was due to the etcd build failing: > • building build={builds-other [illumos] [amd64 arm arm64 riscv64] [v1] [sse2] [6 7] [v8.0] [hardfloat] [power8] [rva20u64] [illumos_amd64_v1] [{linux } {darwin 6 } {darwin arm } {darwin riscv64 } {dragonfly arm } {dragonfly arm64 } {dragonfly riscv64 } {freebsd 7 } {illumos arm } {illumos arm64 } {netbsd riscv64 } {netbsd 7 } {openbsd riscv64 } {openbsd 7 } {windows arm 7 } {windows riscv64 }] . . bao {[] []} go {{ .CommitTimestamp }} false go build false { [-X github.com/openbao/openbao/version.fullVersion={{.Version}} -X github.com/openbao/openbao/version.GitCommit={{.Commit}} -X github.com/openbao/openbao/version.BuildDate={{ .Date }}] [ui] [] [] [] [CGO_ENABLED=0]} []} > • building binary=dist/builds-other_illumos_amd64_v1/bao > • env "CGO_ENABLED=0" evaluated to "CGO_ENABLED=0" > • running > • took: 2m0s > ⨯ release failed after 2m29s error=build failed: failed to build for illumos_amd64_v1: exit status 1: # go.etcd.io/bbolt > Error: ../../../go/pkg/mod/go.etcd.io/[email protected]/bolt_solaris.go:70:15: undefined array length maxMapSize or missing type constraint > > target: illumos_amd64_v1 > Error: Process completed with exit code 1. If this is fixed with a corresponding action build + test verification, we can revert this. See also: etcd-io/bbolt#988 * Bump changelog version to v2.3.1 --------- Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Geoff Wilson <[email protected]>
android will build with error