Bug: All downstream version-bump builds are failing after the rewrite was released

[lumirlumir]

Which packages are affected?

• @eslint/compat
• @eslint/config-array
• @eslint/config-helpers
• @eslint/core
• @eslint/mcp
• @eslint/migrate-config
• @eslint/object-schema
• @eslint/plugin-kit

Environment

Node version: 20.19.4
npm version: 10.9.2
ESLint version: 9.38.0
Operating System: Windows 11

What did you do?

After releasing rewrite yesterday, all downstream version-bump builds have been failing.

I found failures in the following repositories:

• chore: update dependency @eslint/core to ^0.17.0 eslint#20256
• chore: update eslint markdown#572
• chore: update eslint css#314
• chore: update eslint json#174
• chore: update dependency @eslint/core to ^0.17.0 #307

What did you expect to happen?

No CI failures are expected.

What actually happened?

CI fails.

Link to Minimal Reproducible Example

rewrite repository: https://github.com/eslint/rewrite/actions/runs/18911067847/job/53981668641

Participation

• I am willing to submit a pull request for this issue.

Additional comments

I took a stab at this problem, but I am not sure about the exact problem.

In this core package, the following line is causing the problem:

rewrite/packages/core/tests/types/types.test.ts

Lines 480 to 481 in f5ecc7e

	// check back compat
	const oldConfigObjectExample: Linter.Config = configObjectExample;

The following link contains the full git diff for the @eslint/core package:

7f592e3...f5ecc7e#diff-4c2458380e50c967c70d7afe819dc7412180f9f817043f27441de3498e4d0479

What is the correct solution to this problem?

[lumirlumir]

It seems the change in #298 is causing breakages.

When I revert that change and run the CI locally, everything works fine for me.

[eslint-github-bot]

👋 Hi! This issue is being addressed in pull request #309. Thanks, @lumirlumir!

[fasttime]

I think the error will be solved when ESLint is updated to @eslint/core@0.17.0. I'm just not sure why CI was passing before the release in f5ecc7e.

[lumirlumir]

@fasttime It appears that CI did not run for #303:

[fasttime]

I see now what is going on. Before f5ecc7e was merged, packages/core/package.json had version number 0.16.0. ESLint v9.38.0 has a depenency on @eslint/core with range "^0.16.0" that matches 0.16.0, so in that setup, eslint would use the local version of @eslint/core.

After the merge, the version number in packages/core/package.json changes to 0.17.0 which no longer matches "^0.16.0", so now eslint downloads its @eslint/core@0.16.0 from npm and the types no longer match. It's a chicken-and-egg problem because the tests for @eslint/core depend on eslint and eslint depends on @eslint/core. Now that the config type is backed in the core types, we could update the tests to no longer use Linter.Config. i.e.:

- const oldConfigObjectExample: Linter.Config = configObjectExample;

That should already fix the build in this repo. In the other repos, the build will be fixed when ESLint depends on the new version of @eslint/core.