-
-
Notifications
You must be signed in to change notification settings - Fork 37
chore: fix CI failure and ensure the latest @eslint/core is used
#309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 02bac50.
This comment was marked as resolved.
This comment was marked as resolved.
fix in suggestion objects (#298)"fix in suggestion objects (#298)"
fix in suggestion objects (#298)"fix in suggestion objects (#298)"
fix in suggestion objects (#298)"fix in suggestion objects (#298)"
|
Pending verification of #308 (comment). |
|
I'm not sure if it's necessary to merge this fix because this would revert the types to a less correct stand. I think the build is failing because we didn't do a minor release Another way to fix the build failure is to use an overrides in "overrides": {
"eslint": {
"@eslint/core": "file:packages/core"
}
} |
fix in suggestion objects (#298)"@eslint/core is used
|
@fasttime Thanks for the solution and guidance! I've updated this PR according to your comment, and I've also updated the PR title to reflect the change. |
fasttime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Prerequisites checklist
What is the purpose of this pull request?
This PR provides one possible fix for #308.
It partially reverts commit 02bac50.
I'm not entirely sure about this fix for the following reason:
@eslint/coreis in a0.xrelease, so these breakages may be acceptable.fix?: RuleFixer | null | undefined;required undersuggestwouldn't cause a problem, but I think theSuggestedEditBasetype is used incorrectly somewhere, which is causing the issue.I believe there may be a better solution, so please consider this PR a hotfix for the problem. (Or any other suggestions would be welcome.)
What changes did you make? (Give an overview)
This PR provides one possible fix for #308.
It partially reverts commit 02bac50.
Related Issues
Closes: #308
Is there anything you'd like reviewers to focus on?
N/A