Repository navigation
fix(opencode): the model is set once, without a retry - #7
Merged
Merged
Conversation
OpenCode's ACP catalog used to be read before the location's plugins had registered their providers, so a model from OpenCode Console (`opencode-go/*`, `opencode/*`) or from `opencode.json` selected right after `session/new` was refused with -32602. Subturn set the model again after each `config_option_update` for up to 5 s. OpenCode 2.0.25 reads the catalog after the plugins have loaded (anomalyco/opencode#53358, closing #52472 and #52729), so the retry has nothing left to do. It is removed from the ACP turn, together with the fake agent's `latemodel` and `nomodel` modes and their two tests; `configure` takes the client and the session id again. README names 2.0.25 as the minimum OpenCode version. Verified on OpenCode 2.0.26: typecheck and the offline suite (34 pass, 3 live skipped); `subturn status` lists `opencode-go/*` from the first catalog; live smoke + resume on `zai-coding-plan/glm-5.3-flash` and `opencode-go/muse-spark-1.3-contributor`, where the model was acknowledged 19 ms after `session/new`; the user's `opencode.db` gained no session. Claude Fable 5.1 in Claude Code. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5abec03d7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merged
eshatalov
added a commit
that referenced
this pull request
Oct 11, 2026
Version bump for 0.2.0. Minor rather than patch because OpenCode support moved to OpenCode 2 (#6). Ships since 0.1.1: - #5 the newest installed copy of a harness is launched - #6 support OpenCode 2 - #7 OpenCode model is set once, without a retry - #8 Grok's requested model is no longer overridden by launch campaigns - #9 README: the caller's instructions are an inline example Done by Claude Opus 5.5 in Claude Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCode's ACP catalog used to be read before the location's plugins had registered their providers, so a model from OpenCode Console (
opencode-go/*,opencode/*) or fromopencode.jsonselected right aftersession/newwas refused with-32602. Subturn worked around it by setting the model again after eachconfig_option_updatefor up to 5 s.OpenCode 2.0.25 reads the catalog after the plugins have loaded (anomalyco/opencode#53358, closing #52472 and #52729), so the retry has nothing left to do.
src/core/acp-turn.ts:retryOnConfigUpdate, theconfig_option_updatecounter and theconfigure_retryevent are gone;configure(client, sessionId)has two parameters again.src/plugins/opencode.ts,src/plugins/fake.ts: the model is set with onesession/set_config_optioncall. The plugin header no longer describes the late-model behavior.test/fake-agent.mjs,test/core.test.ts: thelatemodelandnomodelmodes and their two tests are removed.README.md: the minimum OpenCode version is 2.0.25.For a reviewer, verified on OpenCode 2.0.26:
npm run typecheck,npm test: 34 pass, 3 live skipped.subturn statuslistsopencode-go/*andopencode/*from the first catalog.zai-coding-plan/glm-5.3-flashand onopencode-go/muse-spark-1.3-contributor, where the model was acknowledged 19 ms aftersession/new. The user'sopencode.dbgained no session. 4 live turns spent.Upstream still delivers providers added by a second activation pass (an npm plugin installed on first run) or by background discovery after the first catalog. The npm cache lives in
XDG_CACHE_HOME, which the shadow does not replace, so a Subturn shadow is not a first run; no retry is kept for that case.Claude Fable 5.1 in Claude Code.
🤖 Generated with Claude Code