[#339] Resolved paths include symlinks #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfacorro
requested review from
robertoaloi and
alanz
and removed request for
robertoaloi
jfacorro
force-pushed
the
339-resolved-paths-include-symlinks
branch
from
257cca0
to
96a0a92
Compare
the-mikedavis
added a commit
to the-mikedavis/erlang_ls
that referenced
this pull request
Oct 24, 2022
…_paths/2` erlang-ls#346 discarded any paths containing symlinks since they broke assumptions about there being a single URI for each module in calls to `els_utils:find_module/1`. erlang-ls#648 added prioritization for cases when there are multiple URIs in `els_utils:find_module/1`, so discarding paths with symlinks is now no longer necessary. Following symlinks is necessary when using rebar3 checkout dependencies (erlang-ls#1046) or when using Bazel (erlang-ls#1064) since Bazel places dependencies and compiled files under its cache directory and symlinks the relevant directory in the cache to the workspace directory. This change removes the behavior of `els_utils:resolve_paths/2` that discards paths containing symlinks.
robertoaloi
pushed a commit
that referenced
this pull request
Nov 8, 2022
#346 discarded any paths containing symlinks since they broke assumptions about there being a single URI for each module in calls to `els_utils:find_module/1`. #648 added prioritization for cases when there are multiple URIs in `els_utils:find_module/1`, so discarding paths with symlinks is now no longer necessary. Following symlinks is necessary when using rebar3 checkout dependencies (#1046) or when using Bazel (#1064) since Bazel places dependencies and compiled files under its cache directory and symlinks the relevant directory in the cache to the workspace directory. This change removes the behavior of `els_utils:resolve_paths/2` that discards paths containing symlinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the
resolve_pathsfunction toels_utilsand modifiy it so that it excludes paths were there is a symlink somewhere between theRootPathargument and the actual path. This is mainly to avoid processing all of the symlinked directories under the_builddirectorie when usingrebar3.Fixes #339.