[#1046,#1064] Follow symlinks in els_utils:resolve_paths/2
#1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_paths/2` erlang-ls#346 discarded any paths containing symlinks since they broke assumptions about there being a single URI for each module in calls to `els_utils:find_module/1`. erlang-ls#648 added prioritization for cases when there are multiple URIs in `els_utils:find_module/1`, so discarding paths with symlinks is now no longer necessary. Following symlinks is necessary when using rebar3 checkout dependencies (erlang-ls#1046) or when using Bazel (erlang-ls#1064) since Bazel places dependencies and compiled files under its cache directory and symlinks the relevant directory in the cache to the workspace directory. This change removes the behavior of `els_utils:resolve_paths/2` that discards paths containing symlinks.
|
Thanks for this @the-mikedavis! We could give this a try and keep an extra eye in case regressions pop up. FYI @alanz @plux in case you have any concerns with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#346 discarded any paths containing symlinks since they broke assumptions about there being a single URI for each module in calls to
els_utils:find_module/1.#648 added prioritization for cases when there are multiple URIs in
els_utils:find_module/1, so discarding paths with symlinks is now no longer necessary.Following symlinks is necessary when using rebar3 checkout dependencies (#1046) or when using Bazel (#1064) since Bazel places dependencies and compiled files under its cache directory and symlinks the relevant directory in the cache to the workspace directory.
This change removes the behavior of
els_utils:resolve_paths/2that discards paths containing symlinks.I tested this in a rebar3 project with checkout dependencies and in a Bazel project and it works well. I haven't noticed any regressions, so I think the changes in #648 fixed the issue in #339.
Fixes #1046.
Fixes #1064.