[#1050] Add separate way to send log notification to avoid recursion #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertoaloi
reviewed
Dec 22, 2021
| @@ -19,7 +19,7 @@ log(#{level := Level} = LogEvent, _Config) -> | |||
| try | |||
| Msg = logger_formatter:format( LogEvent | |||
| , #{ template => ?LSP_LOG_FORMAT}), | |||
| els_server:send_notification(<<"window/logMessage">>, #{ | |||
| els_server:send_log(<<"window/logMessage">>, #{ | |||
There was a problem hiding this comment.
A notification is a LSP concept (as opposed to a request), so I would prefer to maintain the current naming here. Instead, I would add a dedicated clause to the do_send_notification/3 for the window/logMessage method which skips logging. WDYT?
There was a problem hiding this comment.
Makes sense, but I'll include a comment (sort of like filtered out to avoid recurvise logging) so it makes sense why this specific notification is treated differently
There was a problem hiding this comment.
Great idea! Feel free to reference the issue number in the comment.
AminArria
force-pushed
the
fix-recursive-logs
branch
from
393c05b
to
8b489ff
Compare
robertoaloi
approved these changes
Jan 12, 2022
|
Sorry for the long wait. The change looks good, waiting for CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1050