Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop when LSP log level is set to debug #1050

Closed
robertoaloi opened this issue Jul 1, 2021 · 1 comment · Fixed by #1158
Closed

Infinite loop when LSP log level is set to debug #1050

robertoaloi opened this issue Jul 1, 2021 · 1 comment · Fixed by #1158
Labels
bug Something isn't working

Comments

@robertoaloi
Copy link
Member

Now that log messages are sent through the LSP tracing facilities, we have an issue.

If the log level includes DEBUG, that causes all LSP calls to be logged, which in turns causes a new log message, which in turns causes a new LSP message, which in turns causes a new log message, which in turns causes a new LSP message, which in turns causes a new log message, which in turns causes a new LSP message, which in turns causes a new log message, which in turns causes a new LSP message, which in turns causes a new log message, which in turns causes a new LSP message, which in turns causes a new log message, which in turns causes a new LSP message, which in turns causes a new log message, which in turns causes a new LSP message, which in turns causes a new log message, which in turns causes a new LSP message, which in turns causes a new log message, which in turns causes a new LSP message, which in turns causes a new log message, which in turns causes a new LSP message...

@TheGeorge
Copy link
Contributor

Yes, I noticed this when implementing it and honestly forget to address it. I think the log lines that cause this can be removed. The client should be able to log the messages that are send to the server without the server needing to leg these as well.

@TheGeorge TheGeorge added the bug Something isn't working label Jul 1, 2021
AminArria pushed a commit to AminArria/erlang_ls that referenced this issue Dec 17, 2021
AminArria pushed a commit to AminArria/erlang_ls that referenced this issue Dec 23, 2021
robertoaloi added a commit that referenced this issue Jan 13, 2022
[#1050] Add separate way to send log notification to avoid recursion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants