Added a simple function that reads arrays instead of a file #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added array insert instead of file.
Read an arrays instead of a file.
eripe970
reviewed
Jul 31, 2022
io.go
Outdated
| @@ -31,3 +31,16 @@ func ReadSignalFile(path string, sampleRate float64) (*Signal, error) { | |||
| } | |||
| return &signal, scanner.Err() | |||
| } | |||
| // Function allows for reading arrays | |||
| func ReadArray(dataArray []float64, sampleRate float64) (*Signal, error){ | |||
There was a problem hiding this comment.
Do you need to copy the array or can it be like below?
signal := Signal{
SampleRate: sampleRate,
Signal: dataArray,
}
There was a problem hiding this comment.
yah instantiating it would work also!
There was a problem hiding this comment.
I would have to call the type from a different part of the application to update Signal var. I guess totally do able.
There was a problem hiding this comment.
Cool! If you make the change then Ill mergar this PR :)
There was a problem hiding this comment.
I am pretty sure i pushed to the right folder! Been a long week, sorry for the delay.
There was a problem hiding this comment.
I think something like this should work,
func CreateSignalFromArray(signal []float64, sampleRate float64) *Signal {
return &Signal{
SampleRate: sampleRate,
Signal: signal,
}
}
- Replaced the return with &Signal instead of (&Signal, error) since there isn't any error returned
- You can use the array directly, no need to copy the values.
- Changed to name "signal" since I think the go-lang best practice is not to have type name on variables (like dataArray).
This is using the same array as the one that is inserted, if you want to use a deep copy you can use something like
cpy := make([]float64, len(data))
copy(cpy, data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly simple. Just figured I add it if someone else wanted it. May not be be the right approach. But, nice library! Cant wait to learn more about it!