Improve BroadPhase performance#519
Closed
neondev9 wants to merge 2 commits intoerincatto:masterfrom
neondev9:master
Closed
Improve BroadPhase performance#519neondev9 wants to merge 2 commits intoerincatto:masterfrom neondev9:master
neondev9 wants to merge 2 commits intoerincatto:masterfrom
neondev9:master
Conversation
Author
|
Solution: clean the tree from invalid leaves(moved proxies), check the invalid leaf with the tree and reinsert leaf into the tree only after that. |
Owner
|
Sorry, it took me so long to look at this. I'm not sure this will work because it leaves the tree in an invalid state. So if somebody calls b2Body::SetTransform and then performs a raycast then they will get the wrong result. This sort of optimization might be useful if restricted to the world step. I'm guessing the main performance issue is the call to std::sort. I think we could avoid this by comparing the proxy ids. |
Owner
|
See #589 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tumbler 5 minutes test:
Before; 1.03 (Average)
After: 0.71 (Average)