Restore full sync mode #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JekaMas
force-pushed
the
restore-full-sync-mode-#89
branch
from
f68a6b5 to
12759bf
Compare
AlexeyAkhunov
approved these changes
Sep 17, 2019
build/env.sh
Outdated
| @@ -8,20 +8,13 @@ if [ ! -f "build/env.sh" ]; then | |||
| fi | |||
|
|
|||
| # Create fake Go workspace if it doesn't exist yet. | |||
| workspace="$PWD/build/_workspace" | |||
| workspace="$GOPATH" | |||
There was a problem hiding this comment.
This introduces dependency on GOPATH, doesn't it?
There was a problem hiding this comment.
A good point! I had an old master in the branch, now it should be updated.
b00ris
approved these changes
Sep 17, 2019
core/blockchain.go
Outdated
|
|
||
| func (bc *BlockChain) NotifyHeightKnownBlock(h uint64) { | ||
| if atomic.LoadUint64(bc.highestKnownBlock) < h { | ||
| atomic.StoreUint64(bc.highestKnownBlock, h) |
There was a problem hiding this comment.
it could be a datarace. Why Notify?
b00ris
reviewed
Sep 17, 2019
| if block == nil { | ||
| return configKey(-1) | ||
| } | ||
| return configKey(block.Uint64() + 1000) |
JekaMas
force-pushed
the
restore-full-sync-mode-#89
branch
from
812bf14 to
393afd1
Compare
setunapo
pushed a commit
to setunapo/bsc-erigon
that referenced
this pull request
May 30, 2023
battlmonstr
pushed a commit
that referenced
this pull request
Sep 14, 2023
cffls
pushed a commit
to cffls/erigon
that referenced
this pull request
Jan 30, 2024
jyellick
referenced
this pull request
in bobanetwork/op-erigon
Feb 26, 2024
Remove failing TestGnosisForkDigest
taratorio
pushed a commit
that referenced
this pull request
Jul 23, 2024
* more bucketzzz (#87) * save * save * Fix duplicate bucket name, remove presigned URLs (#88) Co-authored-by: Alex Sharp <[email protected]> * toml lint (#89) * save * save * save * save --------- Co-authored-by: Alex Sharov <[email protected]> Co-authored-by: Alex Sharp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #89