Switch FirehoseStateNodes to trie.resolver #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in the resolver
AlexeyAkhunov
approved these changes
Aug 16, 2019
|
|
||
| block := pm.blockchain.GetBlockByHash(blockHash) | ||
| block := pm.blockchain.GetBlockByHash(request.Block) |
There was a problem hiding this comment.
If you only need block to get the block number, there is a more efficient way of doing it, in core/rawdb/accessor_chain.go, func ReadHeaderNumber, however, it requires DatabaseReader. Perhaps it makes sense to access these things not via pm.blockchain, but instead have something like pm.db. This is for future improvements
bgelb
pushed a commit
to bgelb/erigon
that referenced
this pull request
Sep 11, 2023
…pe-check Update erigon-lib version
revitteth
referenced
this pull request
in 0xPolygonHermez/cdk-erigon
Dec 12, 2023
Co-authored-by: Igor Mandrigin <[email protected]>
revitteth
referenced
this pull request
in 0xPolygonHermez/cdk-erigon
Dec 14, 2023
Co-authored-by: Igor Mandrigin <[email protected]>
cffls
pushed a commit
to cffls/erigon
that referenced
this pull request
Jan 30, 2024
taratorio
pushed a commit
that referenced
this pull request
Jul 23, 2024
* more bucketzzz (#87) * save * save * Fix duplicate bucket name, remove presigned URLs (#88) Co-authored-by: Alex Sharp <[email protected]> * toml lint (#89) * save * save * save * save --------- Co-authored-by: Alex Sharov <[email protected]> Co-authored-by: Alex Sharp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.