Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zookeepercli and query_cfgdb to cfgdb VM #176

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Conversation

YanChii
Copy link
Contributor

@YanChii YanChii commented Jun 5, 2017

CFGDB update to resolve erigones/esdc-factory#50

@YanChii YanChii added this to the 2.6.0 milestone Jun 5, 2017
@YanChii YanChii self-assigned this Jun 5, 2017
@YanChii YanChii requested a review from dn0 June 5, 2017 15:02
@@ -0,0 +1,32 @@
# https://github.com/erigones/esdc-factory/issues/50
- name: Download zookeepercli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we download it directly to cfgdb? (it should have the same network configuration as mgmt)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to create new dependency on the internet during update of service virtuals. AFAIK, no mgmt update requires other service VMs to have internet connection.

@YanChii YanChii merged commit fce307a into v2.6 Jun 6, 2017
@YanChii YanChii deleted the cfgdb_zk_client branch June 6, 2017 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants