Reversed order of layer toggles #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 22, 2021 10:31
Represents the deck.gl layer stack more intuitively. Fixes equinor#620
hkfb
added
AspenTech
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
=======================================
Coverage 73.46% 73.46%
=======================================
Files 58 58
Lines 1176 1176
Branches 153 153
=======================================
Hits 864 864
Misses 294 294
Partials 18 18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
This works, but still the layer ordering is governed by the order in which it's defined in deckgl-map.json file. Do we always want layers to be in particular fixed order? If that being the case, we need to do some more changes.
Or for storybook we can change the ordering in deckgl-map.json file instead of dong it here.
The purpose is only to change to a more intuitive representation in the layer selector. This does not and should not affect representation when drawing layers. |
shadab-skhan
approved these changes
Nov 24, 2021
hkfb
added a commit
to hkfb/webviz-subsurface-components
that referenced
this pull request
Nov 29, 2021
* Reversed order of layer toggles. Represents the deck.gl layer stack more intuitively. Fixes equinor#620 * Applied lint conditions. Co-authored-by: Havard Bjerke <[email protected]> Co-authored-by: Shadab Khan <[email protected]>
hkfb
pushed a commit
that referenced
this pull request
Jul 30, 2024
## [0.7.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.7.1) (2024-07-30) ### Bug Fixes * bump fast-xml-parser from 4.4.0 to 4.4.1 in /typescript ([#2175](#2175)) ([1f5f2bf](1f5f2bf)), closes [#634](#634) [#653](#653) [#662](#662) [#654](#654) [#647](#647) [#581](#581) [#582](#582) [#645](#645) [#633](#633) [#607](#607) [#608](#608) [#610](#610) [#589](#589) [#585](#585) [#598](#598) [#595](#595) [#634](#634) [#653](#653) [#662](#662) [#658](#658) [#659](#659)
hkfb
pushed a commit
that referenced
this pull request
Jul 30, 2024
## [1.3.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.3.1) (2024-07-30) ### Bug Fixes * bump fast-xml-parser from 4.4.0 to 4.4.1 in /typescript ([#2175](#2175)) ([1f5f2bf](1f5f2bf)), closes [#634](#634) [#653](#653) [#662](#662) [#654](#654) [#647](#647) [#581](#581) [#582](#582) [#645](#645) [#633](#633) [#607](#607) [#608](#608) [#610](#610) [#589](#589) [#585](#585) [#598](#598) [#595](#595) [#634](#634) [#653](#653) [#662](#662) [#658](#658) [#659](#659)
hkfb
pushed a commit
that referenced
this pull request
Jul 30, 2024
## [0.28.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.28.1) (2024-07-30) ### Bug Fixes * bump fast-xml-parser from 4.4.0 to 4.4.1 in /typescript ([#2175](#2175)) ([1f5f2bf](1f5f2bf)), closes [#634](#634) [#653](#653) [#662](#662) [#654](#654) [#647](#647) [#581](#581) [#582](#582) [#645](#645) [#633](#633) [#607](#607) [#608](#608) [#610](#610) [#589](#589) [#585](#585) [#598](#598) [#595](#595) [#634](#634) [#653](#653) [#662](#662) [#658](#658) [#659](#659)
hkfb
pushed a commit
that referenced
this pull request
Jul 30, 2024
## [1.2.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.2.1) (2024-07-30) ### Bug Fixes * bump fast-xml-parser from 4.4.0 to 4.4.1 in /typescript ([#2175](#2175)) ([1f5f2bf](1f5f2bf)), closes [#634](#634) [#653](#653) [#662](#662) [#654](#654) [#647](#647) [#581](#581) [#582](#582) [#645](#645) [#633](#633) [#607](#607) [#608](#608) [#610](#610) [#589](#589) [#585](#585) [#598](#598) [#595](#595) [#634](#634) [#653](#653) [#662](#662) [#658](#658) [#659](#659)
hkfb
pushed a commit
that referenced
this pull request
Jul 30, 2024
## [1.12.2](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.12.2) (2024-07-30) ### Bug Fixes * bump fast-xml-parser from 4.4.0 to 4.4.1 in /typescript ([#2175](#2175)) ([1f5f2bf](1f5f2bf)), closes [#634](#634) [#653](#653) [#662](#662) [#654](#654) [#647](#647) [#581](#581) [#582](#582) [#645](#645) [#633](#633) [#607](#607) [#608](#608) [#610](#610) [#589](#589) [#585](#585) [#598](#598) [#595](#595) [#634](#634) [#653](#653) [#662](#662) [#658](#658) [#659](#659)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Represents the deck.gl layer stack more intuitively.
Fixes #620