Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unwanted storybook code #654

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Conversation

shruthirai
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #654 (4cdc40f) into master (3b5d1cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #654   +/-   ##
=======================================
  Coverage   72.26%   72.26%           
=======================================
  Files          56       56           
  Lines        1150     1150           
  Branches      150      150           
=======================================
  Hits          831      831           
  Misses        301      301           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5d1cc...4cdc40f. Read the comment docs.

@hkfb hkfb added the AspenTech Task owned by AspenTech label Nov 19, 2021
@hkfb
Copy link
Collaborator

hkfb commented Nov 19, 2021

What is the purpose? Could you give a quick description?

@shruthirai
Copy link
Contributor Author

What is the purpose? Could you give a quick description?

@hkfb This piece of code was written at start but since we already have separate Storybook for discrete and continuous legend now, I think this is not required now.

@shruthirai shruthirai requested a review from hkfb November 19, 2021 09:14
@shruthirai shruthirai merged commit 81b91f0 into equinor:master Nov 19, 2021
@shruthirai shruthirai deleted the Storybook branch November 19, 2021 09:21
hkfb pushed a commit to hkfb/webviz-subsurface-components that referenced this pull request Nov 29, 2021
hkfb pushed a commit that referenced this pull request Jul 30, 2024
hkfb pushed a commit that referenced this pull request Jul 30, 2024
hkfb pushed a commit that referenced this pull request Jul 30, 2024
hkfb pushed a commit that referenced this pull request Jul 30, 2024
hkfb pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AspenTech Task owned by AspenTech
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants