Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/module app/person specific manifest #2520

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

eikeland
Copy link
Contributor

@eikeland eikeland commented Oct 25, 2024

Changes:

  • Updated the AppClient class to modify the query path in the fn method for fetching app manifests:
    • Changed the path from /apps/${appKey} to /persons/me/apps/${appKey}.

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 29cf187

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@equinor/fusion-framework-module-app Patch
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-legacy-interopt Patch
poc-portal Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🚀 feature New feature or request 🚧 chore maintaines work, (update deps, workflos ...) 🧬 Modules labels Oct 25, 2024
@eikeland eikeland changed the base branch from next to main October 31, 2024 09:14
@eikeland eikeland force-pushed the feat/module-app/person-specific-manifest branch from e0a0cf6 to 474f20f Compare October 31, 2024 09:18
@eikeland eikeland marked this pull request as ready for review October 31, 2024 09:18
@eikeland eikeland requested review from odinr and a team as code owners October 31, 2024 09:18
Copy link
Contributor

github-actions bot commented Oct 31, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.39% 1746 / 440988
🔵 Statements 0.39% 1746 / 440988
🔵 Functions 23.8% 219 / 920
🔵 Branches 37.34% 400 / 1071
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/modules/app/src/AppClient.ts 0% 0% 0% 0% 1, 3-4, 6-7, 9, 12-13, 35, 39-55, 57, 60-64, 66-82, 84-101, 103-133, 135-136, 138-139, 141, 144-159, 161-166, 169
Generated in workflow #7937 for commit 29cf187 by the Vitest Coverage Report Action

@eikeland eikeland marked this pull request as draft November 1, 2024 12:49
@eikeland eikeland force-pushed the feat/module-app/person-specific-manifest branch from 474f20f to 0a27a75 Compare November 6, 2024 10:24
@github-actions github-actions bot added the 🐞 bug Something isn't working label Nov 6, 2024
@eikeland eikeland marked this pull request as ready for review November 6, 2024 10:38
@eikeland eikeland force-pushed the feat/module-app/person-specific-manifest branch from b5d0e40 to 158c6d5 Compare November 7, 2024 09:22
@github-actions github-actions bot removed the 🐞 bug Something isn't working label Nov 7, 2024
@eikeland eikeland force-pushed the feat/module-app/person-specific-manifest branch from 158c6d5 to 29cf187 Compare November 7, 2024 09:24
@eikeland eikeland merged commit 248ee1f into main Nov 7, 2024
7 checks passed
@eikeland eikeland deleted the feat/module-app/person-specific-manifest branch November 7, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 chore maintaines work, (update deps, workflos ...) 🚀 feature New feature or request 🧬 Modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants