Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sandpaper from our fork #101

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Install sandpaper from our fork #101

merged 1 commit into from
Jan 24, 2024

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Dec 21, 2023

This is needed because carpentries/sandpaper@main contains the translation feature which is absent from the patch branch.

If we keep installing from the outdated patch branch and try to use the latest varnish version, this will result in missing text.

So we can keep it in sync and keep other workbench pkgs up to date as well
@Bisaloo Bisaloo requested a review from avallecam December 21, 2023 11:49
Copy link

github-actions bot commented Dec 21, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/tutorials/compare/md-outputs..md-outputs-PR-101

The following changes were observed in the rendered markdown documents:

 config.yaml (new) |   82 +++
 md5sum.txt        |    2 +-
 renv.lock (new)   | 1985 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 2068 insertions(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-21 11:51:36 +0000

github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
@avallecam
Copy link
Member

thank you @Bisaloo do you think we should prioritize this to solve #100 to try to get this having everything up-to-date?

@Bisaloo
Copy link
Member Author

Bisaloo commented Dec 21, 2023

The two issues are independent

Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bisaloo , thank you for this PR.

My understanding is that:

This implies that:

This seems to knit well in the git-novice Spanish translation too.

Let me know if I'm missing sth. If not, then, I'll close the cited issues and open some PRs in the required repos.

@Bisaloo
Copy link
Member Author

Bisaloo commented Jan 23, 2024

the maintenance role should (1) keep the epiverse-main fork in sync with the carpentries-main branch, (2) rebase the patch-renv-github-bug feature branch to keep everything up to date.

I can do this since there are a couple of tricky git operations to ensure we keep clean branches with our patches but benefit from the latest workbench features.

thus, we also need to replicate this update in this line epiverse-trace/epimodelac@09d420c/config.yaml#L86

Not yet because I need to sync varnish for this first to get spanish translations with epiverse theme. But I can't do this until tutorials is rendered with the latest sandpaper version because of the issue mentioned in the first comment.

This is a good illustration of the complexity of interdependencies between packages I mentioned in meetings about Epiverse-TRACE scaffolding and architecture.

@avallecam
Copy link
Member

the maintenance role should (1) keep the epiverse-main fork in sync with the carpentries-main branch, (2) rebase the patch-renv-github-bug feature branch to keep everything up to date.

I can do this since there are a couple of tricky git operations to ensure we keep clean branches with our patches but benefit from the latest workbench features.

Thank you for taking the lead on this. Could you register these tricky git operations somewhere? Possibly not now, but we can find some moment to share what steps you followed, or if this scenarios happens again, how to deal with it.

thus, we also need to replicate this update in this line epiverse-trace/epimodelac@09d420c/config.yaml#L86

Not yet because I need to sync varnish for this first to get spanish translations with epiverse theme. But I can't do this until tutorials is rendered with the latest sandpaper version because of the issue mentioned in the first comment.

So, if this means to merge this PR to sync with {varnish}, feel free to merge it as you wish 🚀

This is a good illustration of the complexity of interdependencies between packages I mentioned in meetings about Epiverse-TRACE scaffolding and architecture.

Should this go also to the bucked list of topics for the blog post idea about our experience with the workbench infraestructure?

@Bisaloo
Copy link
Member Author

Bisaloo commented Jan 23, 2024

Should this go also to the bucked list of topics for the blog post idea about our experience with the workbench infraestructure?

Possibly, it could be under a section "if you want to use a custom fork of a given workbench repo, you'll likely need to maintain forks of the others"

@Bisaloo Bisaloo merged commit 309e89b into main Jan 24, 2024
3 checks passed
@Bisaloo Bisaloo deleted the sandpaper-epiverse-trace branch January 24, 2024 08:20
avallecam added a commit to avallecam/workbench-spanish that referenced this pull request Jan 26, 2024
avallecam added a commit to avallecam/workbench-spanish that referenced this pull request Feb 6, 2024
github-actions bot pushed a commit to avallecam/workbench-spanish that referenced this pull request Feb 6, 2024
Auto-generated via {sandpaper}
Source  : 5dcca7c
Branch  : main
Author  : Andree Valle Campos <[email protected]>
Time    : 2024-02-06 16:02:33 +0000
Message : replace draft PR with updated branch

following epiverse-trace/tutorials#101
github-actions bot pushed a commit to avallecam/workbench-spanish that referenced this pull request Feb 6, 2024
Auto-generated via {sandpaper}
Source  : 888c82a
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-02-06 16:05:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5dcca7c
Branch  : main
Author  : Andree Valle Campos <[email protected]>
Time    : 2024-02-06 16:02:33 +0000
Message : replace draft PR with updated branch

following epiverse-trace/tutorials#101
github-actions bot pushed a commit to avallecam/workbench-spanish that referenced this pull request Feb 13, 2024
Auto-generated via {sandpaper}
Source  : 888c82a
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-02-06 16:05:17 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5dcca7c
Branch  : main
Author  : Andree Valle Campos <[email protected]>
Time    : 2024-02-06 16:02:33 +0000
Message : replace draft PR with updated branch

following epiverse-trace/tutorials#101
github-actions bot pushed a commit to avallecam/workbench-spanish that referenced this pull request Feb 20, 2024
Auto-generated via {sandpaper}
Source  : 5dcca7c
Branch  : main
Author  : Andree Valle Campos <[email protected]>
Time    : 2024-02-06 16:02:33 +0000
Message : replace draft PR with updated branch

following epiverse-trace/tutorials#101
github-actions bot pushed a commit to avallecam/workbench-spanish that referenced this pull request Feb 20, 2024
Auto-generated via {sandpaper}
Source  : 7604048
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-02-20 00:32:16 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5dcca7c
Branch  : main
Author  : Andree Valle Campos <[email protected]>
Time    : 2024-02-06 16:02:33 +0000
Message : replace draft PR with updated branch

following epiverse-trace/tutorials#101
avallecam added a commit to avallecam/workbench-spanish that referenced this pull request Feb 20, 2024
avallecam added a commit to avallecam/workbench-spanish that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants