Skip to content

Commit

Permalink
Clarify it is always maintainer regardless of who reviewed or opened
Browse files Browse the repository at this point in the history
  • Loading branch information
Bisaloo committed Mar 10, 2025
1 parent 7674842 commit 497d388
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion git-branching-merging.qmd
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,16 @@ By convention, the package maintainer is in charge of merging the pull requests.
This is indeed often more convenient as they are aware of other ongoing activities in the package that may impact or be impacted with the incoming changes.
We also have a guarantee that maintainers have sufficient permissions to merge the pull request, and potentially bypass some checks if necessary, which may not be the case of the contributor.

This recommendation remains valid even if the maintainer if the author of the pull request and they request review from a non-maintainer.

As a contributor, if you want to signal your changes are not ready to be merged, you should mark your pull requests as draft.

In all cases, communication is key.
As a maintainer, if you see a non draft pull request that looks like it might still receive additional changes, please check in with the contributor before proceeding with the merge.
Conversely, if a PR is marked as draft but seems ready to go, you can check in with the contributor if they have additional changes to make or if the PR can be marked as ready for review.
As a contributor, you can also check in with the maintainer to ensure they have not simply forgotten to merge the changes, especially if they already have approved the PR.

Note that this is only an internal convention and even though we provide reasons why this may be easier, this is not intrinsically better than other conventions.
Note that this is only an internal convention and even though we provide reasons why this may be easier, this is not intrinsically better than other conventions (e.g., PR author always merges or reviewer always merges).
The main goal is to clarify expectations to streamline process and avoid uncertainty-induced action paralysis, where everyone is waiting for the others to merge the PR.

## Deleting merged branches
Expand Down

0 comments on commit 497d388

Please sign in to comment.