Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When by is not null we saw an issue with
add_coverage
highlighted in #223. This appears to be caused by an issue in thedata.table
code. Dropping into debug changing the call to themean
function to be explict (i.ebase::mean
) fixes the issue on my system. If this also causes no reversions on CI etc I'd suggest merging as aa bug fix for bleeding edge users. I can't identify any changes indata.table
that would lead to this change so still hypothetical that this was the system level difference.