-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get type from correct scope #223
Conversation
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 22 22
Lines 1354 1354
=======================================
Hits 1235 1235
Misses 119 119
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This fixed my use case. Shouldn't quantiles
get the same treatment though (even though it's less likely to already have a column named quantiles
in a sample based format)?
yes, good point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We just need to add regression tests for this. I can do it if you'd like.
That would be great, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It would be good to update the news with this fix and a link to this PR at the same time.
I'll let Nikos write the |
Fixes #222