Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check-full.yaml #143

Merged
merged 2 commits into from
Nov 21, 2021
Merged

Conversation

nikosbosse
Copy link
Contributor

Update to remove machines that aren't available and therefore failing

Update to remove machines that aren't available and therefore failing
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #143 (89dc377) into master (1ad1921) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   48.44%   48.44%           
=======================================
  Files          18       18           
  Lines        1348     1348           
=======================================
  Hits          653      653           
  Misses        695      695           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad1921...89dc377. Read the comment docs.

@nikosbosse
Copy link
Contributor Author

I copied this from covidregionaldata. One thing I'm confused about is why it installs RcppArmadillo as a dependency? It shouldn't be a dependency for scoringutils and I think it doesn't get installed on mac and windows... Do you have any ideas @seabbs @Bisaloo ? If nothing comes to mind immediately, don't worry about it. It just makes the job run a little longer which is not too bad.

@nikosbosse nikosbosse merged commit 3b6040d into master Nov 21, 2021
@nikosbosse
Copy link
Contributor Author

ok apparently it also uses RcppArmadillo on windows and mac, but the installation is much much faster. Still confused....

@nikosbosse nikosbosse deleted the nikosbosse-patch-update-gh-actions branch November 25, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant