Update Envoy to dee7021 (Aug 18th 2021).#736
Merged
Conversation
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
oschaaf
previously approved these changes
Aug 19, 2021
Member
oschaaf
left a comment
There was a problem hiding this comment.
the coverage test seems to indicate we started trending low, I'd be surprised if this PR pushed it over the edge, could that be a flake somehow?
That aside, this LGTM
Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
Adjusted the coverage threshold and included explanation in the PR description. PTAL |
oschaaf
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Envoy::Grpc::AsyncClientis created, used and destroyed on the same thread. (See[grpc]: fix ex_authz grpc client race condition envoy#17619). Nighthawk creates the
Envoy::Grpc::AsyncClienton the worker thread, but destroys it on the main which triggers an assertion failure. Fixing this by:RequestSource::destroyOnThread()which complements the pre-existingRequestSource::initOnThread(). While the latter gets called when a worker thread starts, the former now gets called when a worker thread is shutting down.RequestSource::destroyOnThread()on the only request source implementation that usesEnvoy::Grpc::AsyncClient, i.e.Nighthawk::RemoteRequestSourceImpl, the method destroys the object thatowns
Envoy::Grpc::AsyncClientwhen called..bazelrc,.bazelversion,run_envoy_docker.sh.93.2to accommodate the fact that this code path is only covered in integration tests. The unit-tests use a mock.