Update Envoy to 295aba4 (Aug 16 2021) #733
Closed
qqustc wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
Conversation
oschaaf
reviewed
Aug 16, 2021
| Envoy::ThreadLocal::InstanceImpl tls_; | ||
| Envoy::Stats::ThreadLocalStoreImpl store_root_; | ||
| Envoy::Quic::QuicStatNames quic_stat_names_; | ||
| envoy::config::bootstrap::v3::Bootstrap bootstrap_; |
Member
There was a problem hiding this comment.
We do construct a bootstrap:
nighthawk/source/client/process_impl.cc
Line 405 in d05a0c9
Does the bootstrap that we need to start passing into the
Api constructor in this PR need to be in sync with that?
Contributor
Author
There was a problem hiding this comment.
Ah, thanks Otto. I'm not aware about that, currently Api::Impl does not modify the passed in bootstrap. Anyway, I think it is a good idea to pass in the existing bootstrap, will update the PR
Contributor
Author
|
/retest |
|
🔨 rebuilding |
Collaborator
|
Closing this PR as the changes were addressed in: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qqustc@gmail.com qqin@google.com