Skip to content

Update envoy to 0143bc2 (April 26, 2021)#677

Merged
mum4k merged 6 commits intoenvoyproxy:mainfrom
dubious90:envoy-import-20210426
Apr 27, 2021
Merged

Update envoy to 0143bc2 (April 26, 2021)#677
mum4k merged 6 commits intoenvoyproxy:mainfrom
dubious90:envoy-import-20210426

Conversation

@dubious90
Copy link
Contributor

@dubious90 dubious90 commented Apr 26, 2021

  • Sync .bazelrc from Envoy's repository.
  • other necessary files were syncd but unchanged in envoy.
  • The constructor of Envoy::Server::ValidationAdmin now requires an instance of Envoy::Network::Address::InstanceConstSharedPtr, but a nullptr shared_ptr is valid (Fix TAP validation mode envoy#15932)

Also updated some formatting/language in MAINTAINERS.md, which wasn't rendering as intended in markdown.

dubious90 and others added 6 commits February 5, 2021 12:36
@dubious90 dubious90 force-pushed the envoy-import-20210426 branch from af66eef to d9e599d Compare April 26, 2021 22:52
@dubious90 dubious90 requested a review from mum4k April 26, 2021 22:53
@dubious90 dubious90 added the waiting-for-review A PR waiting for a review. label Apr 26, 2021
@dubious90 dubious90 marked this pull request as ready for review April 26, 2021 22:53
@mum4k mum4k changed the title Update envoy to 0143bc2ec23c621c6979687c5998633c9f126aa3 (April 26, 2021) Update envoy to 0143bc2 (April 26, 2021) Apr 27, 2021
Copy link
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind summarizing the necessary code changes and their origin in the PR description? That would simplify review of the code changes.

Example:
#635

@mum4k mum4k added waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. and removed waiting-for-review A PR waiting for a review. labels Apr 27, 2021
@dubious90
Copy link
Contributor Author

@mum4k modified the description as you asked.

@dubious90 dubious90 added waiting-for-review A PR waiting for a review. and removed waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. labels Apr 27, 2021
Copy link
Collaborator

@mum4k mum4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@mum4k mum4k merged commit 95d3411 into envoyproxy:main Apr 27, 2021
wjuan-AFK pushed a commit to wjuan-AFK/nighthawk that referenced this pull request May 11, 2021
- Sync .bazelrc from Envoy's repository.
- other necessary files were syncd but unchanged in envoy.
- The constructor of Envoy::Server::ValidationAdmin now requires an instance of Envoy::Network::Address::InstanceConstSharedPtr, but a nullptr shared_ptr is valid (envoyproxy/envoy#15932)

Also updated some formatting/language in MAINTAINERS.md, which wasn't rendering as intended in markdown.

Signed-off-by: Nathan Perry <nbperry@google.com>
Signed-off-by: William Juan <66322422+wjuan-AFK@users.noreply.github.com>
@dubious90 dubious90 deleted the envoy-import-20210426 branch June 1, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants