Remove deprecated flag allow-envoy-deprecated-v2-api#651
Merged
dubious90 merged 1 commit intoenvoyproxy:mainfrom Mar 18, 2021
Merged
Remove deprecated flag allow-envoy-deprecated-v2-api#651dubious90 merged 1 commit intoenvoyproxy:mainfrom
allow-envoy-deprecated-v2-api#651dubious90 merged 1 commit intoenvoyproxy:mainfrom
Conversation
Contributor
|
@wjuan-AFK Please review and assign back to me once done |
oschaaf
approved these changes
Mar 17, 2021
wjuan-AFK
reviewed
Mar 18, 2021
| runtime_singleton_ = std::make_unique<Envoy::Runtime::ScopedLoaderSingleton>( | ||
| Envoy::Runtime::LoaderPtr{new Envoy::Runtime::LoaderImpl( | ||
| *dispatcher_, tls_, bootstrap.layered_runtime(), *local_info_, store_root_, generator_, | ||
| *dispatcher_, tls_, {}, *local_info_, store_root_, generator_, |
Contributor
There was a problem hiding this comment.
Why is this also being removed?
Contributor
Author
There was a problem hiding this comment.
this is to rollback the change in #584
https://github.com/envoyproxy/nighthawk/pull/584/files#diff-e528c3973715873e2ec7fcac6a842e5d9a59d6523a77bf1219d295dd4c7285cdL481
@oschaaf Otto, is this change ok?
Member
There was a problem hiding this comment.
Yup, lgtm, we no longer need to customize the bootstrap config.
Contributor
|
LGTM |
wjuan-AFK
approved these changes
Mar 18, 2021
dubious90
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated flag
allow-envoy-deprecated-v2-apisince it is no longer supported.It was originally added in PR #584, so this PR is essentially a rollback of #584
Signed-off-by: qqustc@gmail.com qqin@google.com