Add a flag to allow for continued use of the deprecated v2 api#584
Merged
mum4k merged 11 commits intoenvoyproxy:masterfrom Dec 8, 2020
Merged
Add a flag to allow for continued use of the deprecated v2 api#584mum4k merged 11 commits intoenvoyproxy:masterfrom
mum4k merged 11 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Collaborator
|
@dubious90 please review and assign back to me once done. |
dubious90
reviewed
Dec 3, 2020
api/client/options.proto
Outdated
| // "emit_previous_request_delta_in_response_header" to record elapsed time between request | ||
| // arrivals. | ||
| google.protobuf.StringValue latency_response_header_name = 36; | ||
| // Set to allow usage of the v2 api (not recommended). Default is false. |
Contributor
There was a problem hiding this comment.
If we can point to v2 deprecation documentation, that would help people understand why to use or not use this.
Member
Author
There was a problem hiding this comment.
As discussed on Slack, I will follow up on this in #575
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
dubious90
previously approved these changes
Dec 3, 2020
Contributor
dubious90
left a comment
dubious90
left a comment
There was a problem hiding this comment.
LGTM, mum4k to approve
| def DISABLED_test_nighthawk_client_v2_api_breaks_by_default(http_test_server_fixture): | ||
| """Test that the v2 api breaks us when it's not explicitly requested.""" | ||
| parsed_json, _ = http_test_server_fixture.runNighthawkClient([ | ||
| _, _ = http_test_server_fixture.runNighthawkClient([ |
Contributor
There was a problem hiding this comment.
nit and also mildly unfamiliar language for me, but if we don't need either variable here, can we just run the function without assigning the result to anything?
mum4k
requested changes
Dec 4, 2020
mum4k
added
waiting-for-changes
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf
added
waiting-for-review
Member
Author
|
Oh, this needs a merge / conflict resolution, let me fix that. |
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
added
waiting-for-changes
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf
added
waiting-for-review
Member
Author
mum4k
approved these changes
Dec 8, 2020
qqustc
added a commit
to qqustc/nighthawk
that referenced
this pull request
Mar 17, 2021
envoyproxy#584)" This reverts commit 2942dc9. Signed-off-by: qqustc@gmail.com <qqin@google.com>
This was referenced Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revision that deprecated v2 things will keep working as expected, while documenting how to set up the runtime configuration.