Adaptive Load command line client by eric846 · Pull Request #616 · envoyproxy/nighthawk

eric846 · 2021-02-03T04:46:29Z

An adaptive load command line executable that drives a Nighthawk Service with a series of benchmarks, varying the RPS or another input variable dynamically.

bazel build -c opt :nighthawk

bazel-bin/nighthawk_adaptive_load_client

--spec-file pathname
- Pathname of an AdaptiveLoadSessionSpec textproto defining the session
- Required
- Example:test/adaptive_load/test_data/valid_session_spec.textproto
--output-file pathname
- Pathname to write the AdaptiveLoadSessionOutput textproto session output
- Required
--nighthawk-service-address host:port
- Address of the Nighthawk Service to be driven by the adaptive load controller over gRPC
- Default localhost:8443
--use-tls
- Use TLS for the gRPC connection when sending commands to the Nighthawk Service
- Default false (insecure connection)

Note that to run an adaptive load session, you must also have a Nighthawk Service running, e.g.:
bazel-bin/nighthawk_service & (to run at localhost:8443)

Part of #416.

update from master

merge from upstream

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

…double Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

…variable_setter Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

merge from upstream

…ent.Output turns out not to include the status Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

…plugin names, log thresholds only once per session Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 · 2021-02-04T23:50:18Z

/retest

repokitteh-read-only · 2021-02-04T23:50:21Z

🔨 rebuilding ci/circleci: docker (failed build)
🔨 rebuilding ci/circleci: integration_test_coverage (failed build)

🐱

Caused by: a #616 (comment) was created by @eric846.

see: more, trace.

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

…load session spec Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

dubious90 · 2021-02-05T19:08:05Z

@wjuan-AFK Please review and assign to me when done. Also note that we believe the CI failure to be unrelated to these changes.

oschaaf · 2021-02-05T21:04:10Z

@wjuan-AFK Please review and assign to me when done. Also note that we believe the CI failure to be unrelated to these changes.

@dubious90 Created #620 to address the ci trouble with respect to docker.

wjuan-AFK · 2021-02-09T17:30:18Z

source/adaptive_load/adaptive_load_client_main.h

+   * writes the output proto to a file. File paths are taken from class members initialized in the
+   * constructor.
+   *
+   * @return Exit code for this process.


Should we state that 0 is good or is that implicit?

This is a standard in linux, so we can rely on that understanding. https://linuxize.com/post/bash-exit/#exit-status

wjuan-AFK · 2021-02-09T17:34:24Z

source/adaptive_load/adaptive_load_client_main.cc

+  }
+  const Envoy::Api::IoCallSizeResult write_result = file->write(contents);
+  if (!write_result.ok()) {
+    throw Nighthawk::NighthawkException(absl::StrCat("Unable to write output file \"", path,


nit: write to output file.

wjuan-AFK

LGTM

dubious90 · 2021-02-11T18:39:05Z

source/adaptive_load/adaptive_load_client_main.cc

+  output_filename_ = output_filename.getValue();
+}
+
+uint32_t AdaptiveLoadClientMain::Run() {


can we file a future bug to enable some dependency injection of the channel here? in the future, people might want to enable other ways of connecting to the nighthawk service besides the two provided here. but we don't need to prematurely allow for that case until we have a specific usecase.

Filed #626.

dubious90 · 2021-02-11T18:41:05Z

source/adaptive_load/adaptive_load_client_main.h

+   * writes the output proto to a file. File paths are taken from class members initialized in the
+   * constructor.
+   *
+   * @return Exit code for this process.


This is a standard in linux, so we can rely on that understanding. https://linuxize.com/post/bash-exit/#exit-status

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 · 2021-02-11T20:42:17Z

/retest

repokitteh-read-only · 2021-02-11T20:42:20Z

🔨 rebuilding ci/circleci: integration_test_coverage (failed build)
🔨 rebuilding ci/circleci: tsan (failed build)

🐱

Caused by: a #616 (comment) was created by @eric846.

see: more, trace.

eric846 added 30 commits June 1, 2020 17:23

Merge pull request #5 from envoyproxy/master

8ea442d

update from master

Merge pull request #6 from envoyproxy/master

5ac755a

merge from upstream

Merge pull request #7 from envoyproxy/master

b8c25a5

merge from upstream

initial commit

1c19c68

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix comments

7050686

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix format

0776563

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

rename adaptive_rps to adaptive_load

16fd8f6

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add field_selector in example

c383010

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix example comment

6e1a483

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix format

4ef1140

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add support for fault injection headers

4111bf4

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

replace linear and binary search with exponential search

871a959

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add InputVariableSetter mechanism

1fd77c1

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add input variable setter to build file

edc36b2

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix syntax errors

4d0364e

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

rename samples/adaptive_rps

aed6d94

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

improve comments, change step controller initial value from int64 to …

d9ae87d

…double Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add proto validation rules, fix comments, make rps the default input_…

a05a6f5

…variable_setter Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix comment wording

8cd4d21

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

simplify protos, add defaults, specify required or optional

d814a96

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add missing newline

5f5a885

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Kick CI

7e20a78

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

simplify protos

9048267

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix format

306c0ec

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix some optional field comments and rules

d33f543

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge pull request #10 from envoyproxy/master

442cca9

merge from upstream

add Nighthawk status field in BenchmarkResult as nested nighthawk.cli…

677b783

…ent.Output turns out not to include the status Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

switch to standard Envoy plugin config proto, add prefix to internal …

cefb366

…plugin names, log thresholds only once per session Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge remote-tracking branch 'upstream/master' into adaptive-rps-protos2

f3684df

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

create headers

5463051

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 added 5 commits February 4, 2021 16:01

Merge remote-tracking branch 'upstream/main'

4b8ba84

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge branch 'main' into adaptive-rps-cli

15817da

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

try to work around integration test failure

f69619f

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

try not testing ECDHE-RSA-CHACHA20-POLY1305

99c04d3

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix format

77a4ced

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 marked this pull request as ready for review February 5, 2021 17:27

eric846 added the waiting-for-review A PR waiting for a review. label Feb 5, 2021

eric846 added 2 commits February 5, 2021 13:11

remove integration test troubleshooting changes

975c9de

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

replace localhost with 127.0.0.1, improve comment in sample adaptive …

1417e02

…load session spec Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

dubious90 assigned wjuan-AFK and unassigned wjuan-AFK Feb 5, 2021

dubious90 requested a review from wjuan-AFK February 5, 2021 19:06

wjuan-AFK reviewed Feb 9, 2021

View reviewed changes

wjuan-AFK assigned dubious90 Feb 9, 2021

dubious90 previously approved these changes Feb 11, 2021

View reviewed changes

eric846 added 2 commits February 11, 2021 13:47

Merge remote-tracking branch 'upstream/main'

eaa20de

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix typo

11a9161

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 dismissed dubious90’s stale review via 11a9161 February 11, 2021 18:50

eric846 added 2 commits February 11, 2021 13:51

Merge branch 'main' into adaptive-rps-cli

3fa6439

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

apply typo fix in unit test

45dade9

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

dubious90 approved these changes Feb 11, 2021

View reviewed changes

dubious90 merged commit ff42695 into envoyproxy:main Feb 11, 2021

Conversation

eric846 commented Feb 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eric846 commented Feb 4, 2021

Uh oh!

repokitteh-read-only bot commented Feb 4, 2021

Uh oh!

dubious90 commented Feb 5, 2021

Uh oh!

oschaaf commented Feb 5, 2021

Uh oh!

wjuan-AFK Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

dubious90 Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

wjuan-AFK Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

eric846 Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

wjuan-AFK left a comment

Choose a reason for hiding this comment

Uh oh!

dubious90 Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

eric846 Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

dubious90 Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

eric846 commented Feb 11, 2021

Uh oh!

repokitteh-read-only bot commented Feb 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eric846 commented Feb 3, 2021 •

edited

Loading