Improve Unknown Error 13 messages by eric846 · Pull Request #600 · envoyproxy/nighthawk

eric846 · 2020-12-30T16:35:56Z

Migrated to PR #666

Split error conditions as much as possible and add user guidance for further troubleshooting.

Nighthawk Service will now return a more specific error description for the following cases, instead of "unknown," for error 13.

URI exception, with user guidance to check for:
- Malformed URI
- DNS error
Failure predicate, with user guidance to check the output counters to narrow down:
- Connection failures
  - Bad port
  - Bad address family (--address-family v4 or v6) especially when using 'localhost' or DNS
- Stream resets (http/https, --h2)
- 4xx or 5xx received
- gRPC RequestSource error

The CLI output will also include the same new text.

#181 #613

update from master

merge from upstream

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

…double Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

…variable_setter Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

merge from upstream

…ent.Output turns out not to include the status Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

…plugin names, log thresholds only once per session Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 · 2021-03-16T21:24:55Z

I'll reopen this after figuring out the test failures locally.

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

…h again after having added a new one; add data dep for RequestSource yaml Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 · 2021-03-19T00:02:10Z

/retest

repokitteh-read-only · 2021-03-19T00:02:14Z

🔨 rebuilding ci/circleci: integration_test_coverage (failed build)
🔨 rebuilding ci/circleci: tsan (failed build)
🔨 rebuilding ci/circleci: test_gcc (failed build)

🐱

Caused by: a #600 (comment) was created by @eric846.

see: more, trace.

eric846 · 2021-03-19T01:01:42Z

/retest

repokitteh-read-only · 2021-03-19T01:01:45Z

🔨 rebuilding ci/circleci: tsan (failed build)

🐱

Caused by: a #600 (comment) was created by @eric846.

see: more, trace.

eric846 · 2021-03-19T02:26:08Z

/retest

repokitteh-read-only · 2021-03-19T02:26:11Z

🔨 rebuilding ci/circleci: tsan (failed build)

🐱

Caused by: a #600 (comment) was created by @eric846.

see: more, trace.

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 added 30 commits June 1, 2020 17:23

Merge pull request #5 from envoyproxy/master

8ea442d

update from master

Merge pull request #6 from envoyproxy/master

5ac755a

merge from upstream

Merge pull request #7 from envoyproxy/master

b8c25a5

merge from upstream

initial commit

1c19c68

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix comments

7050686

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix format

0776563

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

rename adaptive_rps to adaptive_load

16fd8f6

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add field_selector in example

c383010

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix example comment

6e1a483

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix format

4ef1140

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add support for fault injection headers

4111bf4

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

replace linear and binary search with exponential search

871a959

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add InputVariableSetter mechanism

1fd77c1

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add input variable setter to build file

edc36b2

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix syntax errors

4d0364e

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

rename samples/adaptive_rps

aed6d94

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

improve comments, change step controller initial value from int64 to …

d9ae87d

…double Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add proto validation rules, fix comments, make rps the default input_…

a05a6f5

…variable_setter Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix comment wording

8cd4d21

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

simplify protos, add defaults, specify required or optional

d814a96

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

add missing newline

5f5a885

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Kick CI

7e20a78

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

simplify protos

9048267

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix format

306c0ec

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix some optional field comments and rules

d33f543

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge pull request #10 from envoyproxy/master

442cca9

merge from upstream

add Nighthawk status field in BenchmarkResult as nested nighthawk.cli…

677b783

…ent.Output turns out not to include the status Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

switch to standard Envoy plugin config proto, add prefix to internal …

cefb366

…plugin names, log thresholds only once per session Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge remote-tracking branch 'upstream/master' into adaptive-rps-protos2

f3684df

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

create headers

5463051

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 added 6 commits March 8, 2021 16:30

Merge remote-tracking branch 'upstream/main'

be5c0fa

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge remote-tracking branch 'upstream/main'

7da182a

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge remote-tracking branch 'upstream/main'

d3e5545

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge branch 'main' into error13

32307e1

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge remote-tracking branch 'upstream/main'

2f44065

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge branch 'main' into error13

2cd7d47

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 closed this Mar 16, 2021

eric846 added 3 commits March 17, 2021 19:32

Merge remote-tracking branch 'upstream/main'

190a691

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge branch 'main' into error13

33d1913

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

fix integration test failures: avoid random failure predicate mismatc…

1035b2d

…h again after having added a new one; add data dep for RequestSource yaml Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 reopened this Mar 18, 2021

eric846 added 5 commits March 18, 2021 13:17

Merge remote-tracking branch 'upstream/main'

74de764

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

return ok status when execution was cancelled

a27b30a

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

update process_test to anticipate ok status when cancelling

7bda479

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge remote-tracking branch 'upstream/main'

c2baebd

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge branch 'main' into error13

1d00bbb

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 added 6 commits March 22, 2021 17:27

Merge remote-tracking branch 'upstream/main'

da83218

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

merge from upstream`

f954fca

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge remote-tracking branch 'upstream/main'

e78adac

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

merge from upstream

aeb9882

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge remote-tracking branch 'upstream/main'

f79c078

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

Merge branch 'main' into error13

e8f074c

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>

eric846 closed this Mar 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Unknown Error 13 messages#600

Improve Unknown Error 13 messages#600
eric846 wants to merge 106 commits intoenvoyproxy:mainfrom
eric846:error13

eric846 commented Dec 30, 2020 •

edited

Loading

Uh oh!

eric846 commented Mar 16, 2021

Uh oh!

eric846 commented Mar 19, 2021

Uh oh!

repokitteh-read-only bot commented Mar 19, 2021

Uh oh!

eric846 commented Mar 19, 2021

Uh oh!

repokitteh-read-only bot commented Mar 19, 2021

Uh oh!

eric846 commented Mar 19, 2021

Uh oh!

repokitteh-read-only bot commented Mar 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

eric846 commented Dec 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Migrated to PR #666

Uh oh!

eric846 commented Mar 16, 2021

Uh oh!

eric846 commented Mar 19, 2021

Uh oh!

repokitteh-read-only bot commented Mar 19, 2021

Uh oh!

eric846 commented Mar 19, 2021

Uh oh!

repokitteh-read-only bot commented Mar 19, 2021

Uh oh!

eric846 commented Mar 19, 2021

Uh oh!

repokitteh-read-only bot commented Mar 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eric846 commented Dec 30, 2020 •

edited

Loading