Skip to content

Adaptive load controller main loop#526

Closed
eric846 wants to merge 76 commits intoenvoyproxy:masterfrom
eric846:adaptive-rps-main-loop-short
Closed

Adaptive load controller main loop#526
eric846 wants to merge 76 commits intoenvoyproxy:masterfrom
eric846:adaptive-rps-main-loop-short

Conversation

@eric846
Copy link
Copy Markdown
Contributor

@eric846 eric846 commented Sep 11, 2020

Adaptive load controller object which contains the main loop:

  • Validates the adaptive load session spec
  • Performs adjusting stage:
    • Gets latest load value from StepController
    • Calls Nighthawk Service
    • Scores metrics
    • Checks StepController for convergence and doom
    • Checks for timeout
  • Calls Nighthawk Service for one last testing stage benchmark with the latest load value
  • Returns an output proto

Part 7 of splitting PR #483.

eric846 added 30 commits June 1, 2020 17:23
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
…double

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
…variable_setter

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
…ent.Output turns out not to include the status

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
…plugin names, log thresholds only once per session

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
…op-short

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
…loop-short

Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846 eric846 marked this pull request as ready for review September 11, 2020 19:33
@eric846 eric846 added the waiting-for-review A PR waiting for a review. label Sep 11, 2020
@dubious90
Copy link
Copy Markdown
Contributor

Before I send this out to review, can you break it up into smaller pieces if it's not too much work? This PR is currently 25 files
You know the code better obviously, but in an initial scan, it looks to me like there are three things happening here that could be separate PRs:

  1. The main Adaptive Load Loop
  2. Mock Metrics Evaluator
  3. Some cleanup work around declaring const/PURE and such
    a. This appears to be most of the files, but few of the lines, and splitting it out will likely make that review very easy, while reducing the overhead on the other reviews.

@dubious90 dubious90 added waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. and removed waiting-for-review A PR waiting for a review. labels Sep 11, 2020
@eric846 eric846 closed this Sep 11, 2020
@eric846
Copy link
Copy Markdown
Contributor Author

eric846 commented Sep 11, 2020

Before I send this out to review, can you break it up into smaller pieces if it's not too much work? This PR is currently 25 files
You know the code better obviously, but in an initial scan, it looks to me like there are three things happening here that could be separate PRs:

  1. The main Adaptive Load Loop
  2. Mock Metrics Evaluator
  3. Some cleanup work around declaring const/PURE and such
    a. This appears to be most of the files, but few of the lines, and splitting it out will likely make that review very easy, while reducing the overhead on the other reviews.

Will do, closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-changes A PR waiting for comments to be resolved and changes to be applied.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants