Skip to content

Coverage: HttpTestServerDecoderFilter::sendReply() #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mum4k merged 1 commit into from
Apr 27, 2020
Merged

Coverage: HttpTestServerDecoderFilter::sendReply() #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion test/server/http_test_server_filter_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
namespace Nighthawk {

using namespace testing;
constexpr absl::string_view kBadJson = "bad_json";

class HttpTestServerIntegrationTestBase : public Envoy::HttpIntegrationTest,
public TestWithParam<Envoy::Network::Address::IpVersion> {
Expand Down Expand Up @@ -258,6 +259,20 @@ TEST_P(HttpTestServerIntegrationNoConfigTest, TestHeaderConfig) {
EXPECT_EQ("", response->body());
}

TEST_P(HttpTestServerIntegrationNoConfigTest, BadTestHeaderConfig) {
Envoy::BufferingStreamDecoderPtr response = makeSingleRequest(
lookupPort("http"), "GET", "/", "", downstream_protocol_, version_, "foo.com", "",
[](Envoy::Http::RequestHeaderMapImpl& request_headers) {
request_headers.addCopy(Nighthawk::Server::TestServer::HeaderNames::get().TestServerConfig,
kBadJson);
});
ASSERT_TRUE(response->complete());
EXPECT_EQ("500", response->headers().Status()->value().getStringView());
EXPECT_EQ("test-server didn't understand the request: Error merging json config: Unable to parse "
"JSON as proto (INVALID_ARGUMENT:Unexpected token.\nbad_json\n^): bad_json",
response->body());
}

class HttpTestServerDecoderFilterTest : public Test {};

// Here we test config-level merging as well as its application at the response-header level.
Expand Down Expand Up @@ -314,7 +329,7 @@ TEST_F(HttpTestServerDecoderFilterTest, HeaderMerge) {
header_map, Envoy::Http::TestResponseHeaderMapImpl{
{":status", "200"}, {"foo", "bar2"}, {"foo2", "bar3"}}));

EXPECT_FALSE(f.mergeJsonConfig(R"(bad_json)", options, error_message));
EXPECT_FALSE(f.mergeJsonConfig(kBadJson, options, error_message));
EXPECT_EQ("Error merging json config: Unable to parse JSON as proto (INVALID_ARGUMENT:Unexpected "
"token.\nbad_json\n^): bad_json",
error_message);
Expand Down