Release notes for v0.2 + doc update#100
Conversation
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
README.md
Outdated
|
|
||
| ```bash | ||
| bazel build -c opt //:nighthawk_client | ||
| bazel build -c opt //... |
There was a problem hiding this comment.
I think providing a concrete build target is a good idea.
README.md
Outdated
|
|
||
| ```bash | ||
| bazel test -c dbg //test:nighthawk_test | ||
| bazel test -c dbg //... |
README.md
Outdated
| ``` | ||
| ### Using the service | ||
|
|
||
| The grpc service can be used to start a server which is able to perform back-to-back benchmark runs upon request. The service interface definition [can be found here.](https://github.com/envoyproxy/nighthawk/blob/59a37568783272a6438b5697277d4e56aa16ebbe/api/client/service.proto) |
README.md
Outdated
| bazel build -c opt //:nighthawk_client | ||
| bazel build -c opt //... | ||
| ``` | ||
| ### Using the service |
There was a problem hiding this comment.
I would move this to after the CLI section and call it ### Nighthawk gRPC service
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
|
/assign @htuch comments addressed! |
|
neither of comments, addressed! can be assigned to this issue. |
|
|
||
| ```bash | ||
| bazel test -c dbg //test:nighthawk_test | ||
| bazel test -c dbg //test/... //integration/... |
There was a problem hiding this comment.
Can we move integration underneath test? It seems cleaner to have all tests in a single tree?
There was a problem hiding this comment.
That is where they lived at first, but it caused problems with the coverage test:
https://circleci.com/gh/envoyproxy/nighthawk/1193?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
There was a problem hiding this comment.
Can you update to use the new LLVM-style coverage script? See envoyproxy/envoy#7552. This might not fix it, but it makes coverage much faster and easier to debug :)
README.md
Outdated
|
|
||
| ```bash | ||
| bazel build -c opt //:nighthawk_client | ||
| bazel build -c opt //:nighthawk_client nighthawk_test_server nighthawk_service |
There was a problem hiding this comment.
Does this work? Don't the latest binaries need a path? Also, should we just have a filegroup or something for this?
There was a problem hiding this comment.
Yes this works. I will look into creating a filegroup.
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
|
@htuch this now incorporates a filegroup |
2 participants
No description provided.