coverage: use LLVM and bazel native coverage#7552
Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
This is ready, still using single binary though LLVM and bazel native coverage. CI fails because coverage is below threshold (96.94%). The report is here and should be compared to coverage report from #7566: https://248596-65214191-gh.circle-artifacts.com/0/coverage/index.html |
|
@lizan agreed let's drop the % required for now and ship it. Looking through there is legit coverage missing so maybe we can raise it again one day. Q: Which project(s) would we file issues against to get the ability to exclude lines back? It seems like something that shouldn't be that hard to do and maybe we could list as a starter project somewhere. (Either way let's open an issue to track further coverage improvements.) /wait |
|
@mattklein123 With #7568 I think 97.0% is the threshold we can use for now. It is 0.5% down from currently, which is the gap of excluded lines.
It is |
|
/retest |
|
🔨 rebuilding |
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
This is awesome, thanks a ton for working on this. Can we have a follow up issue for excluding lines and maybe link to an LLVM issue that we can track? One other question.
/wait-any
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
|
There is already one in LLVM actually: https://bugs.llvm.org/show_bug.cgi?id=34277 |
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Amazing! (Might want to see if @htuch wants to take a quick look since he is more familiar with all of this, but LGTM and we can always ship and iterate.)
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Fantastic, two minors nit and LGTM. This is a huge win!
|
@asraa FYI, this should change how coverage is done in OSS Envoy and it should make it faster to iterate around the nghttp2 coverage effort. |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM once you sort out coverage fail.
#7552 breaks master coverage build. Risk Level: Low Testing: cannot be tested via presubmit only Docs Changes: n/a Release Notes: n/a Signed-off-by: Lizan Zhou <lizan@tetrate.io>
3 participants
Signed-off-by: Lizan Zhou lizan@tetrate.io
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes: