feat: add linter for release notes filename validation#8139
Closed
Nexusrex18 wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
feat: add linter for release notes filename validation#8139Nexusrex18 wants to merge 1 commit intoenvoyproxy:mainfrom
Nexusrex18 wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Signed-off-by: Nexusrex18 <lavisnj350@gmail.com>
Nexusrex18
force-pushed
the
fix/linter-release-notes
branch
from
16457de to
5fd106a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8139 +/- ##
==========================================
- Coverage 73.74% 73.70% -0.04%
==========================================
Files 240 240
Lines 36470 36470
==========================================
- Hits 26896 26882 -14
- Misses 7672 7685 +13
- Partials 1902 1903 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Sorry @Nexusrex18 there's #8137 for this. |
Member
|
Closing this as #8137 got merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
In this PR, I added a linter to validate release notes filenames follow the SemVer convention, preventing issues like the one in #8133 where release notes had incorrect paths/names.
What this PR does / why we need it:
tools/hack/verify-release-notes.shscript to validate filenamestools/make/lint.mkto run withmake lintrelease-notes/*.yamlandsite/content/en/news/releases/notes/*.mdQuestions for Maintainers
v0.2.0-rc1.yamlshould bev0.2.0-rc.1.yamlv0.2.0-rc2.yamlshould bev0.2.0-rc.2.yamlv1.7.0-rc1.yamlshould bev1.7.0-rc.1.yamlWhich issue(s) this PR fixes:
Fixes #8134