Skip to content

fix: replace context.TODO with timeout context in config dump#8122

Merged
arkodg merged 3 commits into
envoyproxy:mainfrom
jaffarkeikei:fix/context-todo-config-dump
Feb 1, 2026
Merged

fix: replace context.TODO with timeout context in config dump#8122
arkodg merged 3 commits into
envoyproxy:mainfrom
jaffarkeikei:fix/context-todo-config-dump

test: add unit tests for config dump timeout functionality

0cf2ac3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2026 in 1s

73.65% (target 60.00%)

View this Pull Request on Codecov

73.65% (target 60.00%)

Details

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.65%. Comparing base (42522ff) to head (0cf2ac3).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
internal/troubleshoot/collect/config_dump.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8122      +/-   ##
==========================================
- Coverage   73.65%   73.65%   -0.01%     
==========================================
  Files         239      240       +1     
  Lines       36311    36467     +156     
==========================================
+ Hits        26745    26859     +114     
- Misses       7670     7703      +33     
- Partials     1896     1905       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.