Skip to content

fix wrong enum on SubjectAltNameType #6307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 1 commit into from
Jun 13, 2025
Merged

fix wrong enum on SubjectAltNameType #6307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/gatewayapi/backendtlspolicy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,9 @@ func getBackendTLSBundle(backendTLSPolicy *gwapiv1a3.BackendTLSPolicy, resources
for _, san := range backendTLSPolicy.Spec.Validation.SubjectAltNames {
var subjectAltName ir.SubjectAltName
switch san.Type {
case "DNS":
case gwapiv1a3.HostnameSubjectAltNameType:
subjectAltName.Hostname = ptr.To(string(san.Hostname))
case "URI":
case gwapiv1a3.URISubjectAltNameType:
subjectAltName.URI = ptr.To(string(san.URI))
default:
continue // skip unknown types
Expand Down
2 changes: 1 addition & 1 deletion internal/gatewayapi/testdata/backendtlspolicy-subjectaltnames.in.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,5 +133,5 @@ backendTLSPolicies:
subjectAltNames:
- type: URI
uri: spiffe://cluster.local/ns/istio-demo/sa/echo-v1
- type: DNS
- type: Hostname
hostname: subdomain.secondexample.com
2 changes: 1 addition & 1 deletion internal/gatewayapi/testdata/backendtlspolicy-subjectaltnames.out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ backendTLSPolicies:
- type: URI
uri: spiffe://cluster.local/ns/istio-demo/sa/echo-v1
- hostname: subdomain.secondexample.com
type: DNS
type: Hostname
status:
ancestors:
- ancestorRef:
Expand Down
1 change: 1 addition & 0 deletions release-notes/current.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ bug fixes: |
Fixed issue where WASM cache init failure caused routes with WASM-less EnvoyExtensionPolicies to have 500 direct responses.
Fixed issue which UDP listeners were not created in the Envoy proxy config when Gateway was created.
Keep ALPN configuration for listeners with overlapping certificates when ALPN is explicitly set in ClientTrafficPolicy.
Fixed issue that switch on wrong SubjectAltNameType enum value in BackendTLSPolicy.

# Enhancements that improve performance.
performance improvements: |
Expand Down