Skip to content

fix wrong enum on SubjectAltNameType#6307

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
zirain:fix-san-type
Jun 13, 2025
Merged

fix wrong enum on SubjectAltNameType#6307
arkodg merged 1 commit intoenvoyproxy:mainfrom
zirain:fix-san-type

Conversation

@zirain
Copy link
Member

@zirain zirain commented Jun 13, 2025

Valid values for SubjectAltNameType as following:

// SubjectAltNameType is the type of the Subject Alternative Name.
// +kubebuilder:validation:Enum=Hostname;URI
type SubjectAltNameType string

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner June 13, 2025 11:37
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.60%. Comparing base (e0e8a29) to head (1b713fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6307      +/-   ##
==========================================
- Coverage   70.60%   70.60%   -0.01%     
==========================================
  Files         220      220              
  Lines       36829    36829              
==========================================
- Hits        26004    26003       -1     
  Misses       9292     9292              
- Partials     1533     1534       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arkodg arkodg merged commit c5835dd into envoyproxy:main Jun 13, 2025
27 checks passed
@zirain
Copy link
Member Author

zirain commented Jun 13, 2025

@arkodg need cherry-pick? at least for v1.4?

@zirain zirain deleted the fix-san-type branch June 13, 2025 13:45
@arkodg
Copy link
Contributor

arkodg commented Jun 13, 2025

yeah we need to, will add the label to it, thanks @zirain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants