feat: support custom redirects#6295
Merged
zirain merged 1 commit intoenvoyproxy:mainfrom Jun 13, 2025
rudrakhp:feat_custom_redirect
Merged
feat: support custom redirects#6295zirain merged 1 commit intoenvoyproxy:mainfrom rudrakhp:feat_custom_redirect
zirain merged 1 commit intoenvoyproxy:mainfrom
rudrakhp:feat_custom_redirect
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6295 +/- ##
==========================================
+ Coverage 70.55% 70.58% +0.03%
==========================================
Files 220 220
Lines 36771 36829 +58
==========================================
+ Hits 25943 25997 +54
- Misses 9293 9297 +4
Partials 1535 1535 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Jun 12, 2025
internal/ir/xds.go
Outdated
Contributor
There was a problem hiding this comment.
can you add a omitempty to both the fields, so they dont show up as null in test file
Member
Author
There was a problem hiding this comment.
nice catch added it in the existing Redirect struct as well
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
Member
Author
|
/retest |
zirain
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: support custom redirects in BackendTrafficPolicy
What this PR does / why we need it:
To support setting redirect responses in custom response overrides.
Which issue(s) this PR fixes:
Fixes #5475
Related #5549
Release Notes: Yes/No