api: support headers and redirects in custom response#5549
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Jun 3, 2025
rudrakhp:api_redirect_response
Merged
api: support headers and redirects in custom response#5549arkodg merged 1 commit intoenvoyproxy:mainfrom rudrakhp:api_redirect_response
arkodg merged 1 commit intoenvoyproxy:mainfrom
rudrakhp:api_redirect_response
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5549 +/- ##
==========================================
- Coverage 70.47% 70.39% -0.09%
==========================================
Files 220 220
Lines 36593 36593
==========================================
- Hits 25788 25758 -30
- Misses 9282 9303 +21
- Partials 1523 1532 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
hey @rudrakhp sorry couldn't get to this sooner, since we are too close to v1.4, this will probably need to be included in v1.5 |
arkodg
reviewed
May 23, 2025
rudrakhp
commented
May 29, 2025
Member
Author
|
/retest |
Contributor
|
thanks for the updates @rudrakhp, apart from the one comment, LGTM from my side |
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
arkodg
approved these changes
May 30, 2025
zhaohuabing
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
api: support headers and redirects in custom response
What this PR does / why we need it:
Extends the
CustomResponseAPI to support adding response headers and redirect responses.Which issue(s) this PR fixes:
Related #5475