decouple Gateway API version with go mod#6210
Merged
zirain merged 2 commits intoenvoyproxy:mainfrom May 28, 2025
Merged
Conversation
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6210 +/- ##
==========================================
+ Coverage 70.43% 70.46% +0.02%
==========================================
Files 220 220
Lines 36593 36593
==========================================
+ Hits 25775 25785 +10
+ Misses 9290 9282 -8
+ Partials 1528 1526 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
previously approved these changes
May 28, 2025
Member
|
Can we also update the gateway-api go mod to the latest commit to test if there are any potential issues? |
rudrakhp
reviewed
May 28, 2025
| # GATEWAY_API_VERSION refers to the version of Gateway API CRDs. | ||
| # For more details, see https://gateway-api.sigs.k8s.io/guides/getting-started/#installing-gateway-api | ||
| GATEWAY_API_VERSION ?= $(shell go list -m -f '{{.Version}}' sigs.k8s.io/gateway-api) | ||
| GATEWAY_API_VERSION ?= v1.3.0 |
Member
There was a problem hiding this comment.
Curious if we should be testing against a different version than the one being used for building EG. Or does backward compatibility guarantee validity of the tests?
Member
There was a problem hiding this comment.
I think this is acceptable for the latest dev image. We always pin Gateway API version for a release.
Signed-off-by: zirain <zirain2009@gmail.com>
cnvergence
approved these changes
May 28, 2025
arkodg
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allow EG adopt changes for conformace test before a offical release.