[Backport 7.75.x][VULN-15676] Upgrade github.com/envoyproxy/gateway (#45496)#45809
Conversation
Ran `go get github.com/envoyproxy/gateway@v1.5.7` https://datadoghq.atlassian.net/browse/VULN-15676 Co-authored-by: JSGette <joseph.gette@datadoghq.com> Co-authored-by: eliott.bouhana <eliott.bouhana@datadoghq.com> (cherry picked from commit 2e582b2)
Go Package Import DifferencesBaseline: c6b79bd
|
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: c6b79bd Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -1.04 | [-3.96, +1.87] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | otlp_ingest_logs | memory utilization | +0.83 | [+0.73, +0.93] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.49 | [+0.28, +0.70] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.38 | [+0.17, +0.58] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.30 | [+0.25, +0.35] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.23 | [-0.00, +0.46] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.22 | [+0.18, +0.27] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | +0.18 | [+0.11, +0.26] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.13 | [-0.08, +0.34] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.07 | [+0.01, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.02 | [-0.35, +0.39] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.00 | [-0.12, +0.13] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.07, +0.08] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.14, +0.12] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.05, +0.04] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.01 | [-0.40, +0.39] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.39, +0.37] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.06 | [-0.10, -0.03] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | -0.14 | [-1.59, +1.31] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | -0.24 | [-0.31, -0.17] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.47 | [-0.62, -0.32] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.62 | [-0.68, -0.55] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.63 | [-0.78, -0.47] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -1.04 | [-3.96, +1.87] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Signed-off-by: Wassim DHIF <wassim.dhif@datadoghq.com>
There was a problem hiding this comment.
Pull request overview
This PR backports an upgrade of github.com/envoyproxy/gateway from v1.3.3 to v1.5.7 to address security vulnerability VULN-15676. The upgrade also brings in several transitive dependency updates, including gateway-api, Docker CLI, MySQL driver, PostgreSQL driver, and various container registry and OpenAPI libraries.
Changes:
- Upgrades envoyproxy/gateway from v1.3.3 to v1.5.7 (2 minor versions)
- Updates multiple transitive dependencies to newer versions
- Adjusts Docker cluster agent size limits to accommodate slight increases from dependency updates
Reviewed changes
Copilot reviewed 9 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates envoyproxy/gateway and related direct dependencies (hcsshim, go-sql-driver/mysql, go-containerregistry, jackc/pgx/v5, gateway-api, honnef.co/go/tools) |
| go.sum | Updates checksums for all dependency changes including transitive dependencies |
| test/new-e2e/go.mod | Updates docker/cli and go-containerregistry dependencies for e2e tests |
| test/new-e2e/go.sum | Updates checksums for test framework dependencies |
| test/e2e-framework/go.mod | Updates docker/cli dependency for e2e framework |
| test/e2e-framework/go.sum | Updates checksums for e2e framework dependencies |
| pkg/fleet/installer/go.mod | Updates go-containerregistry dependency for fleet installer |
| pkg/fleet/installer/go.sum | Updates checksums for fleet installer dependencies |
| comp/otelcol/*/go.mod | Updates OpenAPI and envoyproxy dependencies for OTel collector components |
| comp/otelcol/*/go.sum | Updates checksums for OTel collector component dependencies |
| test/static/static_quality_gates.yml | Increases size limits for Docker cluster agent to accommodate dependency updates (~120 KiB increase) |
| LICENSE-3rdparty.csv | Adds new dependency licenses and updates copyright information for updated dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
212a623
into
7.75.x
Backport 2e582b2 from #45649.
What does this PR do?
Ran
go get github.com/envoyproxy/gateway@v1.5.7Motivation
https://datadoghq.atlassian.net/browse/VULN-15676
Describe how you validated your changes
Additional Notes