Skip to content

feat: improve egctl collect #6197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zirain merged 2 commits into from
May 28, 2025

proxy-namespaces

35d4553
Select commit
Loading
Failed to load commit list.
Merged

feat: improve egctl collect #6197

proxy-namespaces
35d4553
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 28, 2025 in 1s

70.52% (target 60.00%)

View this Pull Request on Codecov

70.52% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (cbb5381) to head (35d4553).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/troubleshoot/collect.go 0.00% 33 Missing ⚠️
...nternal/troubleshoot/collect/prometheus_metrics.go 0.00% 30 Missing ⚠️
internal/cmd/egctl/collect.go 0.00% 12 Missing ⚠️
internal/cmd/egctl/root.go 0.00% 2 Missing ⚠️
internal/utils/str/strconv.go 0.00% 2 Missing ⚠️
internal/troubleshoot/collect/config_dump.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6197      +/-   ##
==========================================
- Coverage   70.61%   70.52%   -0.10%     
==========================================
  Files         219      220       +1     
  Lines       36515    36526      +11     
==========================================
- Hits        25786    25760      -26     
- Misses       9201     9239      +38     
+ Partials     1528     1527       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov