Skip to content

feat: improve egctl collect#6197

Merged
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:egctl/collect
May 28, 2025
Merged

feat: improve egctl collect#6197
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:egctl/collect

Conversation

@zirain
Copy link
Member

@zirain zirain commented May 27, 2025

  1. support collect other namespace for GNM(gateway namesapce mode)
  2. mute klog
  3. correct prometheus scrape logic

@zirain zirain requested a review from a team as a code owner May 27, 2025 04:08
Signed-off-by: zirain <zirain2009@gmail.com>
@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (cbb5381) to head (35d4553).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/troubleshoot/collect.go 0.00% 33 Missing ⚠️
...nternal/troubleshoot/collect/prometheus_metrics.go 0.00% 30 Missing ⚠️
internal/cmd/egctl/collect.go 0.00% 12 Missing ⚠️
internal/cmd/egctl/root.go 0.00% 2 Missing ⚠️
internal/utils/str/strconv.go 0.00% 2 Missing ⚠️
internal/troubleshoot/collect/config_dump.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6197      +/-   ##
==========================================
- Coverage   70.61%   70.52%   -0.10%     
==========================================
  Files         219      220       +1     
  Lines       36515    36526      +11     
==========================================
- Hits        25786    25760      -26     
- Misses       9201     9239      +38     
+ Partials     1528     1527       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: zirain <zirain2009@gmail.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@zirain zirain merged commit b4006b7 into envoyproxy:main May 28, 2025
42 of 45 checks passed
@zirain zirain deleted the egctl/collect branch May 28, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants