add unix domain socket path length validation#6160
Merged
rudrakhp merged 1 commit intoenvoyproxy:mainfrom May 25, 2025
Merged
Conversation
Signed-off-by: mukeshmahato17 <mukeshmahato1089@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6160 +/- ##
==========================================
- Coverage 70.52% 70.47% -0.05%
==========================================
Files 219 219
Lines 36342 36345 +3
==========================================
- Hits 25629 25615 -14
- Misses 9192 9203 +11
- Partials 1521 1527 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
hey @arkodg the TestEGUpgrade test failed in CI during the upgrade sequence with resource cleanup operations, while the Envoy shutdown portion passes successfully (might be). Could you please re-run the test? |
Contributor
|
/retest |
rudrakhp
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR adds validation to limit Unix domain socket path length to 108 characters, which is the standard limit across Unix systems. This limitation exists for historical reasons related to the kernel's mbuf (memory buffer) data structure in early BSD implementations.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #6150
Release Notes: Yes