fix: add unix domain socket path length validation#6150
Closed
mukeshmahato17 wants to merge 3 commits intoenvoyproxy:mainfrom
Closed
fix: add unix domain socket path length validation#6150mukeshmahato17 wants to merge 3 commits intoenvoyproxy:mainfrom
mukeshmahato17 wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
rudrakhp
reviewed
May 22, 2025
api/v1alpha1/backend_types.go
Outdated
Member
There was a problem hiding this comment.
Suggested change
| // +kubebuilder:validation:XValidation:rule="self.size() <= 108",message="Unix domain socket path length must not exceed 108 characters" | |
Do we need this validation after +kubebuilder:validation:MaxLength=108?
Contributor
Author
There was a problem hiding this comment.
hm, yes we don't need redundant validation that is unnecessary
mukeshmahato17
force-pushed
the
udslength
branch
2 times, most recently
from
e44ded6 to
ef4dcd7
Compare
Member
|
@mukeshmahato17 run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6150 +/- ##
==========================================
+ Coverage 70.52% 70.54% +0.02%
==========================================
Files 219 219
Lines 36342 36342
==========================================
+ Hits 25629 25638 +9
+ Misses 9192 9184 -8
+ Partials 1521 1520 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: mukeshmahato17 <mukeshmahato1089@gmail.com>
Signed-off-by: mukeshmahato17 <mukeshmahato1089@gmail.com>
rudrakhp
reviewed
May 22, 2025
test/cel-validation/backend_test.go
Outdated
Member
There was a problem hiding this comment.
can we have a new test instead of replacing an existing one?
Contributor
Author
There was a problem hiding this comment.
actually this was merge conflict. i resolved the conflict only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds validation to limit Unix domain socket path length to 108 characters, which is the standard limit across Unix systems. This limitation exists for historical reasons related to the kernel's mbuf (memory buffer) data structure in early BSD implementations.
Which issue(s) this PR fixes:
Fixes #6145
Release Notes: Yes