local_ratelimit: make sure x-ratelimit-reset exists#6157
Merged
zirain merged 1 commit intoenvoyproxy:mainfrom May 27, 2025
Merged
local_ratelimit: make sure x-ratelimit-reset exists#6157zirain merged 1 commit intoenvoyproxy:mainfrom
zirain merged 1 commit intoenvoyproxy:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6157 +/- ##
==========================================
- Coverage 70.61% 70.58% -0.04%
==========================================
Files 219 219
Lines 36511 36511
==========================================
- Hits 25784 25773 -11
- Misses 9199 9210 +11
Partials 1528 1528 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
force-pushed
the
local-ratelimit-header/reset
branch
from
b41eb8f to
838015d
Compare
zhaohuabing
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #5693
xref: envoyproxy/envoy#39501 #6059