Skip to content

feat: local ratelimit support XRateLimitHeaders #6059

Merged
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:local_ratelimit_headers
May 21, 2025
Merged

feat: local ratelimit support XRateLimitHeaders #6059
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:local_ratelimit_headers

Conversation

@zirain
Copy link
Member

@zirain zirain commented May 14, 2025

xref: #5693

@zirain zirain requested a review from a team as a code owner May 14, 2025 03:11
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.51%. Comparing base (35420d5) to head (05b1203).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/local_ratelimit.go 50.00% 2 Missing and 1 partial ⚠️
internal/xds/translator/httpfilters.go 50.00% 0 Missing and 1 partial ⚠️
internal/xds/translator/route.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6059      +/-   ##
==========================================
- Coverage   70.54%   70.51%   -0.03%     
==========================================
  Files         217      217              
  Lines       36226    36229       +3     
==========================================
- Hits        25554    25546       -8     
- Misses       9159     9169      +10     
- Partials     1513     1514       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zirain zirain force-pushed the local_ratelimit_headers branch 7 times, most recently from 9786349 to 71498f1 Compare May 19, 2025 09:59
@zirain zirain added this to the v1.5.0-rc.1 Release milestone May 19, 2025
arkodg
arkodg previously approved these changes May 20, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the local_ratelimit_headers branch from 71498f1 to 05b1203 Compare May 20, 2025 23:50
@zirain zirain requested a review from arkodg May 20, 2025 23:50
@zirain zirain merged commit eb7266c into envoyproxy:main May 21, 2025
27 checks passed
@zirain zirain deleted the local_ratelimit_headers branch May 21, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants