Skip to content

change default component log level to misc:error #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zirain merged 1 commit into from
May 22, 2025
Merged

change default component log level to misc:error #6149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/infrastructure/common/proxy_args.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ func BuildProxyArgs(

if componentsLogLevel := logging.GetEnvoyProxyComponentLevel(); componentsLogLevel != "" {
args = append(args, fmt.Sprintf("--component-log-level %s", componentsLogLevel))
} else {
// Default to error level for misc components if not set.
Copy link
Copy Markdown
Contributor

@arkodg arkodg May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be moved to

gateway/api/v1alpha1/envoyproxy_helpers.go

Line 132 in c09c42c

func (logging *ProxyLogging) GetEnvoyProxyComponentLevel() string {
?

Copy link
Copy Markdown
Member Author

@zirain zirain May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both are fine to me, I change send a follow up if you want.

Copy link
Copy Markdown
Contributor

@arkodg arkodg May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure that would be great if we can keep the source of truth of defaults inside GetEnvoyProxyComponentLevel rather than in the caller

args = append(args, fmt.Sprintf("--component-log-level %s", "misc:error"))
}

// Default drain timeout.
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/custom.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/default-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/disable-prometheus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/extension-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions .../infrastructure/kubernetes/proxy/testdata/daemonsets/override-labels-and-annotations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/patch-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/shutdown-manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 30
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/volumes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-annotations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-concurrency.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ spec:
- --cpuset-threads
- --drain-strategy immediate
- --concurrency 4
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-extra-args.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
- --key1 val1
- --key2 val2
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-image-pull-secrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-name.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/daemonsets/with-node-selector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions ...infrastructure/kubernetes/proxy/testdata/daemonsets/with-topology-spread-constraints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/bootstrap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/custom.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions ...rnal/infrastructure/kubernetes/proxy/testdata/deployments/custom_with_initcontainers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/default-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/disable-prometheus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/dual-stack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/extension-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/ipv6.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions ...infrastructure/kubernetes/proxy/testdata/deployments/override-labels-and-annotations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/patch-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/shutdown-manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 30
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/volumes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-annotations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-concurrency.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ spec:
- --cpuset-threads
- --drain-strategy immediate
- --concurrency 4
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-empty-memory-limits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-extra-args.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
- --key1 val1
- --key2 val2
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-image-pull-secrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-name.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/deployments/with-node-selector.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
1 change: 1 addition & 0 deletions ...nfrastructure/kubernetes/proxy/testdata/deployments/with-topology-spread-constraints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down
2 changes: 2 additions & 0 deletions internal/infrastructure/kubernetes/proxy/testdata/gateway-namespace-mode/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down Expand Up @@ -697,6 +698,7 @@ spec:
- --log-level warn
- --cpuset-threads
- --drain-strategy immediate
- --component-log-level misc:error
- --drain-time-s 60
command:
- envoy
Expand Down