change default component log level to misc:error#6149
Merged
zirain merged 1 commit intoenvoyproxy:mainfrom May 22, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6149 +/- ##
==========================================
- Coverage 70.52% 70.47% -0.05%
==========================================
Files 219 219
Lines 36342 36345 +3
==========================================
- Hits 25629 25614 -15
- Misses 9192 9207 +15
- Partials 1521 1524 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: zirain <zirain2009@gmail.com>
cnvergence
approved these changes
May 22, 2025
arkodg
reviewed
May 22, 2025
| if componentsLogLevel := logging.GetEnvoyProxyComponentLevel(); componentsLogLevel != "" { | ||
| args = append(args, fmt.Sprintf("--component-log-level %s", componentsLogLevel)) | ||
| } else { | ||
| // Default to error level for misc components if not set. |
Contributor
There was a problem hiding this comment.
Should this be moved to
gateway/api/v1alpha1/envoyproxy_helpers.go
Line 132 in c09c42c
Member
Author
There was a problem hiding this comment.
both are fine to me, I change send a follow up if you want.
Contributor
There was a problem hiding this comment.
sure that would be great if we can keep the source of truth of defaults inside GetEnvoyProxyComponentLevel rather than in the caller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #5983